From: Brian Foster <bfoster@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, Carlos Maiolino <cmaiolino@redhat.com>,
Dave Chinner <dchinner@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: move two more RT specific functions into CONFIG_XFS_RT
Date: Fri, 13 Oct 2017 09:24:27 -0400 [thread overview]
Message-ID: <20171013132427.GC44461@bfoster.bfoster> (raw)
In-Reply-To: <20171013120603.4135344-1-arnd@arndb.de>
On Fri, Oct 13, 2017 at 02:05:40PM +0200, Arnd Bergmann wrote:
> The last cleanup introduced two harmless warnings:
>
> fs/xfs/xfs_fsmap.c:480:1: warning: '__xfs_getfsmap_rtdev' defined but not used
> fs/xfs/xfs_fsmap.c:372:1: warning: 'xfs_getfsmap_rtdev_rtbitmap_helper' defined but not used
>
> This moves those two functions as well.
>
> Fixes: bb9c2e543325 ("xfs: move more RT specific code under CONFIG_XFS_RT")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
I don't reproduce the warning, but the patch looks fine:
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_fsmap.c | 48 ++++++++++++++++++++++++------------------------
> 1 file changed, 24 insertions(+), 24 deletions(-)
>
> diff --git a/fs/xfs/xfs_fsmap.c b/fs/xfs/xfs_fsmap.c
> index 560e0b40ac1b..43cfc07996a4 100644
> --- a/fs/xfs/xfs_fsmap.c
> +++ b/fs/xfs/xfs_fsmap.c
> @@ -367,29 +367,6 @@ xfs_getfsmap_datadev_helper(
> return xfs_getfsmap_helper(cur->bc_tp, info, rec, rec_daddr);
> }
>
> -/* Transform a rtbitmap "record" into a fsmap */
> -STATIC int
> -xfs_getfsmap_rtdev_rtbitmap_helper(
> - struct xfs_trans *tp,
> - struct xfs_rtalloc_rec *rec,
> - void *priv)
> -{
> - struct xfs_mount *mp = tp->t_mountp;
> - struct xfs_getfsmap_info *info = priv;
> - struct xfs_rmap_irec irec;
> - xfs_daddr_t rec_daddr;
> -
> - rec_daddr = XFS_FSB_TO_BB(mp, rec->ar_startblock);
> -
> - irec.rm_startblock = rec->ar_startblock;
> - irec.rm_blockcount = rec->ar_blockcount;
> - irec.rm_owner = XFS_RMAP_OWN_NULL; /* "free" */
> - irec.rm_offset = 0;
> - irec.rm_flags = 0;
> -
> - return xfs_getfsmap_helper(tp, info, &irec, rec_daddr);
> -}
> -
> /* Transform a bnobt irec into a fsmap */
> STATIC int
> xfs_getfsmap_datadev_bnobt_helper(
> @@ -475,6 +452,30 @@ xfs_getfsmap_logdev(
> return xfs_getfsmap_helper(tp, info, &rmap, 0);
> }
>
> +#ifdef CONFIG_XFS_RT
> +/* Transform a rtbitmap "record" into a fsmap */
> +STATIC int
> +xfs_getfsmap_rtdev_rtbitmap_helper(
> + struct xfs_trans *tp,
> + struct xfs_rtalloc_rec *rec,
> + void *priv)
> +{
> + struct xfs_mount *mp = tp->t_mountp;
> + struct xfs_getfsmap_info *info = priv;
> + struct xfs_rmap_irec irec;
> + xfs_daddr_t rec_daddr;
> +
> + rec_daddr = XFS_FSB_TO_BB(mp, rec->ar_startblock);
> +
> + irec.rm_startblock = rec->ar_startblock;
> + irec.rm_blockcount = rec->ar_blockcount;
> + irec.rm_owner = XFS_RMAP_OWN_NULL; /* "free" */
> + irec.rm_offset = 0;
> + irec.rm_flags = 0;
> +
> + return xfs_getfsmap_helper(tp, info, &irec, rec_daddr);
> +}
> +
> /* Execute a getfsmap query against the realtime device. */
> STATIC int
> __xfs_getfsmap_rtdev(
> @@ -521,7 +522,6 @@ __xfs_getfsmap_rtdev(
> return query_fn(tp, info);
> }
>
> -#ifdef CONFIG_XFS_RT
> /* Actually query the realtime bitmap. */
> STATIC int
> xfs_getfsmap_rtdev_rtbitmap_query(
> --
> 2.9.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-10-13 13:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 12:05 [PATCH] xfs: move two more RT specific functions into CONFIG_XFS_RT Arnd Bergmann
2017-10-13 13:24 ` Brian Foster [this message]
2017-10-13 16:26 ` Darrick J. Wong
2017-10-13 22:08 ` Dave Chinner
2017-10-14 11:11 ` Brian Foster
2017-10-16 7:41 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013132427.GC44461@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=arnd@arndb.de \
--cc=cmaiolino@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.