From: Al Viro <viro@ZenIV.linux.org.uk>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
linux-fsdevel@vger.kernel.org,
Jeff Layton <jlayton@poochiereds.net>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] vfs: shutdown lease notifications on file close
Date: Fri, 13 Oct 2017 18:01:06 +0100 [thread overview]
Message-ID: <20171013170105.GF21978@ZenIV.linux.org.uk> (raw)
In-Reply-To: <150791017031.39579.15556617763195969964.stgit@dwillia2-desk3.amr.corp.intel.com>
On Fri, Oct 13, 2017 at 08:56:10AM -0700, Dan Williams wrote:
> While implementing MAP_DIRECT, an mmap flag that arranges for an
> FL_LAYOUT lease to be established, Al noted:
>
> You are not even guaranteed that descriptor will remain be still
> open by the time you pass it down to your helper, nevermind the
> moment when event actually happens...
>
> The first problem can be solved with an fd{get,put} at mmap
> {entry,exit}.
Huh? fdget() does *NOT* guarantee that descriptor won't get closed. What
it does is guarantee that struct file won't get closed under you, which
is nowhere near the same thing. And while we are at it, it certainly
_is_ called by mmap()...
> The second problem appears to be a general issue.
>
> Leases follow the lifetime of the inode, so it is possible for a lease
> to be broken after the file is closed. When that happens userspace may
> get a notification on a stale fd. Of course it is not recommended that a
> process close a file descriptor with an active lease, but if it does we
> should assume that the notification is not needed either. Walk leases at
> close time and invalidate any pending fasync instances.
What the hell is special about close(2) and not, e.g. dup2(2)? Or execve(2)
triggering close-on-exec, etc... Besides, you are changing a user-visible
behaviour here. Suppose your process forks and the child closes all
descriptors; should that stop SIGIO delivery to the parent?
Let's step back for a minute; could you describe how the userland is supposed
to use that thing?
next prev parent reply other threads:[~2017-10-13 17:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 15:56 [RFC PATCH] vfs: shutdown lease notifications on file close Dan Williams
2017-10-13 17:01 ` Al Viro [this message]
2017-10-13 17:43 ` Dan Williams
2017-10-13 18:00 ` Dan Williams
2017-10-13 18:30 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013170105.GF21978@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=bfields@fieldses.org \
--cc=dan.j.williams@intel.com \
--cc=jlayton@poochiereds.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.