From: Sakari Ailus <sakari.ailus@iki.fi>
To: "Zhi, Yong" <yong.zhi@intel.com>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"sakari.ailus@linux.intel.com" <sakari.ailus@linux.intel.com>,
"Zheng, Jian Xu" <jian.xu.zheng@intel.com>,
"Mani, Rajmohan" <rajmohan.mani@intel.com>,
"Yang, Hyungwoo" <hyungwoo.yang@intel.com>,
"Hu, Jerry W" <jerry.w.hu@intel.com>
Subject: Re: [PATCH v3 08/12] intel-ipu3: params: compute and program ccs
Date: Fri, 20 Oct 2017 18:01:39 +0300 [thread overview]
Message-ID: <20171020150139.wmd5zmxf5zb3llcd@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <C193D76D23A22742993887E6D207B54D1AE2AF59@ORSMSX106.amr.corp.intel.com>
On Fri, Oct 20, 2017 at 02:51:07PM +0000, Zhi, Yong wrote:
> > > + /* flip table to for convolution reverse indexing */
> > > + s64 coeff = coeffs[coeffs_size -
> > > + ((tap * (coeffs_size / taps)) +
> > > + phase) - 1];
> > > + coeff *= mantissa;
> > > + coeff /= input_width;
> >
> > Please use do_div() so this will compile on 32-bit machines.
> >
>
> Thanks, above was implemented in v4.
Yeah, I noticed that later. I accidentally reviewed an older version. ;)
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi
next prev parent reply other threads:[~2017-10-20 15:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 3:13 [PATCH v3 01/12] videodev2.h, v4l2-ioctl: add IPU3 meta buffer format Yong Zhi
2017-07-19 3:13 ` [PATCH v3 04/12] intel-ipu3: Add user space ABI definitions Yong Zhi
2017-07-19 3:13 ` [PATCH v3 06/12] intel-ipu3: css: imgu dma buff pool Yong Zhi
2017-07-19 3:13 ` [PATCH v3 07/12] intel-ipu3: css: firmware management Yong Zhi
2017-07-19 3:13 ` [PATCH v3 08/12] intel-ipu3: params: compute and program ccs Yong Zhi
2017-10-20 9:58 ` Sakari Ailus
2017-10-20 14:51 ` Zhi, Yong
2017-10-20 15:01 ` Sakari Ailus [this message]
2017-07-19 3:13 ` [PATCH v3 09/12] intel-ipu3: css hardware setup Yong Zhi
2017-07-19 3:13 ` [PATCH v3 10/12] intel-ipu3: css pipeline Yong Zhi
2017-07-19 3:13 ` [PATCH v3 11/12] intel-ipu3: Add imgu v4l2 driver Yong Zhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171020150139.wmd5zmxf5zb3llcd@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=hyungwoo.yang@intel.com \
--cc=jerry.w.hu@intel.com \
--cc=jian.xu.zheng@intel.com \
--cc=linux-media@vger.kernel.org \
--cc=rajmohan.mani@intel.com \
--cc=sakari.ailus@linux.intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.