From: Brian Foster <bfoster@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: validate sb_logsunit is a multiple of the fs blocksize
Date: Tue, 24 Oct 2017 08:54:13 -0400 [thread overview]
Message-ID: <20171024125412.GC56184@bfoster.bfoster> (raw)
In-Reply-To: <20171024002844.GM5483@magnolia>
On Mon, Oct 23, 2017 at 05:28:44PM -0700, Darrick J. Wong wrote:
> Make sure the log stripe unit is sane before proceeding with mounting.
> AFAICT this means that logsunit has to be 0, 1, or a multiple of the fs
> block size. Found this by setting the LSB of logsunit in xfs/350 and
> watching the system crash as soon as we try to write to the log.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/xfs_log.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
> index d729e00..da4dcab 100644
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -659,6 +659,12 @@ xfs_log_mount(
> XFS_FSB_TO_B(mp, mp->m_sb.sb_logblocks),
> XFS_MAX_LOG_BYTES);
> error = -EINVAL;
> + } else if (mp->m_sb.sb_logsunit > 1 &&
> + mp->m_sb.sb_logsunit % mp->m_sb.sb_blocksize) {
> + xfs_warn(mp,
> + "log stripe unit %u bytes must be a multiple of block size",
> + mp->m_sb.sb_logsunit);
> + error = -EINVAL;
Looks fine, but I notice that the error handling just below only fails
the mount on v5 filesystems. Otherwise we warn and carry on. I'm not
sure why that is.. but is this a crash vector on v4 filesystems as well?
Brian
> }
> if (error) {
> if (xfs_sb_version_hascrc(&mp->m_sb)) {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-10-24 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 0:28 [PATCH] xfs: validate sb_logsunit is a multiple of the fs blocksize Darrick J. Wong
2017-10-24 12:54 ` Brian Foster [this message]
2017-10-24 18:18 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024125412.GC56184@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.