From: Eryu Guan <eguan@redhat.com>
To: Gu Jinxiang <gujx@cn.fujitsu.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] xfstests: Add message indicating btrfs-progs support FST in read-only mode
Date: Thu, 26 Oct 2017 14:52:18 +0800 [thread overview]
Message-ID: <20171026065218.GK3235@eguan.usersys.redhat.com> (raw)
In-Reply-To: <1508997466-12859-1-git-send-email-gujx@cn.fujitsu.com>
On Thu, Oct 26, 2017 at 01:57:46PM +0800, Gu Jinxiang wrote:
> From: Gu JinXiang <gujx@cn.fujitsu.com>
>
> btrfs-progs now support FST in read-only mode, so when space_cache=v2
> enabled, this test case will fail.
> Add message to help user to understand this status.
Sorry, I don't quite understand the new 'FST' feature. But is it a bug
that we want to fix when mounting with space_cache=v2 option, or we just
couldn't do btrfs-convert in this case? If it's a real bug, I'd say let
the test fail as it is, and track bug in tools like bugzilla not
comments/messages in the test; if it's the latter case, then just
_notrun the test if space_cache=v2 option is specified, e.g.
_exclude_scratch_mount_option "space_cache=v2"
Thanks,
Eryu
>
> Signed-off-by: Gu JinXiang <gujx@cn.fujitsu.com>
> ---
> tests/btrfs/012 | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tests/btrfs/012 b/tests/btrfs/012
> index 85c82f07..529e6eca 100755
> --- a/tests/btrfs/012
> +++ b/tests/btrfs/012
> @@ -96,6 +96,12 @@ cp -aR /lib/modules/`uname -r`/ $SCRATCH_MNT/new
>
> _scratch_unmount
>
> +space_cache_version=$(echo "$MOUNT_OPTIONS" | grep "space_cache=v2")
> +if [ -n "$space_cache_version" ]; then
> + _fail "since used space_cache=v2 when mount," \
> + "and for FST btrfs-progs support is read-only."\
> + "so btrfs-convert rollback will fail"
> +fi
> # Now restore the ext4 device
> $BTRFS_CONVERT_PROG -r $SCRATCH_DEV >> $seqres.full 2>&1 || \
> _fail "btrfs-convert rollback failed"
> --
> 2.13.5
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-10-26 6:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 5:57 [PATCH] xfstests: Add message indicating btrfs-progs support FST in read-only mode Gu Jinxiang
2017-10-26 6:52 ` Eryu Guan [this message]
2017-10-26 7:13 ` Qu Wenruo
2017-10-26 7:32 ` Qu Wenruo
2017-10-26 7:16 ` Gu, Jinxiang
2017-10-26 7:34 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026065218.GK3235@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=gujx@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.