From: David Sterba <dsterba@suse.cz>
To: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.cz
Subject: Re: [PATCH 0/3] add_qgroup/update_qgroup/__qgroup_search cleanup
Date: Thu, 9 Nov 2017 17:55:23 +0100 [thread overview]
Message-ID: <20171109165523.GP27557@twin.jikos.cz> (raw)
In-Reply-To: <20171031091345.9325-1-lufq.fnst@cn.fujitsu.com>
On Tue, Oct 31, 2017 at 05:13:42PM +0800, Lu Fengqi wrote:
> Patch 1 just remove the redundant function add_qgroup.
> Patch 2 separate QGROUP_INFO/QGROUP_LIMIT/QGROUP_RELATION process from
> the update_qgroup.
> Patch 3 mainly the coding style adjustment.
This per-patch description is fine, and not always necessary if the
patch subjects and changelogs are sufficient. The cover letter could be
some overview what are the patches addressing.
>
> Lu Fengqi (3):
> btrfs-progs: qgroup: cleanup the redundant function add_qgroup
> btrfs-progs: qgroup: split update_qgroup to reduce arguments
1 and 2 applied, the cleanups look very good, thanks.
> btrfs-progs: qgroup: cleanup __qgroup_search, no functional change
Not applied, please see the comments.
prev parent reply other threads:[~2017-11-09 16:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 9:13 [PATCH 0/3] add_qgroup/update_qgroup/__qgroup_search cleanup Lu Fengqi
2017-10-31 9:13 ` [PATCH 1/3] btrfs-progs: qgroup: cleanup the redundant function add_qgroup Lu Fengqi
2017-10-31 9:13 ` [PATCH 2/3] btrfs-progs: qgroup: split update_qgroup to reduce arguments Lu Fengqi
2017-10-31 9:13 ` [PATCH 3/3] btrfs-progs: qgroup: cleanup __qgroup_search, no functional change Lu Fengqi
2017-11-09 16:51 ` David Sterba
2017-11-10 9:57 ` Lu Fengqi
2017-11-09 16:55 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109165523.GP27557@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=lufq.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.