From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: Re: [PATCH v1] iio: magnetometer: ak8975: Remove wrong ACPI ID
Date: Sun, 19 Nov 2017 15:05:38 +0000 [thread overview]
Message-ID: <20171119150538.2683f77c@archlinux> (raw)
In-Reply-To: <1510159119.25007.116.camel@linux.intel.com>
On Wed, 08 Nov 2017 18:38:39 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Sun, 2017-11-05 at 18:03 -0800, Srinivas Pandruvada wrote:
> > On Sun, 2017-11-05 at 14:42 +0200, Andy Shevchenko wrote:
> > > On Fri, 2017-11-03 at 11:46 -0700, Srinivas Pandruvada wrote:
>
> > > > The AK8963 is using INVN6500. The reason is that this INVN 6500
> > > > has
> > > > another master mode where a secondary sensor can be connected to
> > > > it
> > > > as
> > > > an i2c slave.
> > > > So Windows config uses this mode and hence added in the same
> > > > package.
> > > >
> > > > But Linux INVN driver is not capable of this master mode. We use
> > > > something called "bypass" mode. In this the second sensor will
> > > > also
> > > > be
> > > > directly connected to host i2c. We have another driver handling
> > > > this
> > > > sensor (ak8975), so we have to add this id.
> > >
> > > But ak8975 is enumerated. See above log. So, I think the INVN6500 ID
> > > in
> > > ak 8975 driver is simple not required.
> >
> > This is not true in all platforms. So this is required.
>
> Thanks for clarification. though it would be interesting to test a
> behaviour w/o this patch on platform I have and the one that has wrong
> data under CNF0 resources.
>
As this discussion seems to have concluded the patch is a bad
idea I'm dropping it.
I'll add though that it would be possible to instantiate the ak8975 from
the mpu6050 driver if we wanted to avoid this nasty 'hack'.
Jonathan
prev parent reply other threads:[~2017-11-19 15:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 17:56 [PATCH v1] iio: magnetometer: ak8975: Remove wrong ACPI ID Andy Shevchenko
2017-11-03 18:08 ` Andy Shevchenko
2017-11-03 18:14 ` Andy Shevchenko
2017-11-03 18:46 ` Srinivas Pandruvada
2017-11-05 12:42 ` Andy Shevchenko
2017-11-06 2:03 ` Srinivas Pandruvada
2017-11-08 16:38 ` Andy Shevchenko
2017-11-19 15:05 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171119150538.2683f77c@archlinux \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.