From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: David Weinehall <david.weinehall@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915: Don't use GEN6_RC_VIDEO_FREQ on gen10+
Date: Mon, 20 Nov 2017 14:33:52 -0800 [thread overview]
Message-ID: <20171120223352.ltwu7ojwagg6oes6@intel.com> (raw)
In-Reply-To: <20171117080146.20150-1-david.weinehall@linux.intel.com>
On Fri, Nov 17, 2017 at 08:01:46AM +0000, David Weinehall wrote:
> GEN6_RC_VIDEO_FREQ is deprecated for >= gen10;
> don't try to program it.
>
> v2: Use IS_GEN9() instead of INTEL_GEN() and remove comment (Rodrigo)
>
> Signed-off-by: David Weinehall <david.weinehall@linux.intel.com>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Merged to dinq. Thanks for the patch.
> ---
> drivers/gpu/drm/i915/intel_pm.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 8c69ec9eb6ee..8f6c02477226 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -6583,9 +6583,10 @@ static void gen9_enable_rps(struct drm_i915_private *dev_priv)
> {
> intel_uncore_forcewake_get(dev_priv, FORCEWAKE_ALL);
>
> - /* Program defaults and thresholds for RPS*/
> - I915_WRITE(GEN6_RC_VIDEO_FREQ,
> - GEN9_FREQUENCY(dev_priv->gt_pm.rps.rp1_freq));
> + /* Program defaults and thresholds for RPS */
> + if (IS_GEN9(dev_priv))
> + I915_WRITE(GEN6_RC_VIDEO_FREQ,
> + GEN9_FREQUENCY(dev_priv->gt_pm.rps.rp1_freq));
>
> /* 1 second timeout*/
> I915_WRITE(GEN6_RP_DOWN_TIMEOUT,
> --
> 2.15.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-11-20 22:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 14:29 [PATCH] drm/i915: Don't use GEN6_RC_VIDEO_FREQ on gen10+ David Weinehall
2017-11-10 15:03 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-11-10 17:21 ` ✓ Fi.CI.IGT: " Patchwork
2017-11-10 19:53 ` [PATCH] " Rodrigo Vivi
2017-11-13 14:06 ` David Weinehall
2017-11-13 18:20 ` Rodrigo Vivi
2017-11-17 8:01 ` [PATCH v2] " David Weinehall
2017-11-20 22:33 ` Rodrigo Vivi [this message]
2017-11-17 8:26 ` ✓ Fi.CI.BAT: success for drm/i915: Don't use GEN6_RC_VIDEO_FREQ on gen10+ (rev2) Patchwork
2017-11-17 9:11 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-11-17 18:29 ` ✓ Fi.CI.BAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171120223352.ltwu7ojwagg6oes6@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=david.weinehall@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.