Re: [PATCH] xen-netfront: remove warning when unloading module

From: kbuild test robot <lkp@intel.com>
To: Eduardo Otubo <otubo@redhat.com>
Cc: kbuild-all@01.org, xen-devel@lists.xenproject.org,
	netdev@vger.kernel.org, paul.durrant@citrix.com,
	wei.liu2@citrix.com, linux-kernel@vger.kernel.org,
	vkuznets@redhat.com, cavery@redhat.com, cheshi@redhat.com,
	mgamal@redhat.com, Eduardo Otubo <otubo@redhat.com>
Subject: Re: [PATCH] xen-netfront: remove warning when unloading module
Date: Wed, 22 Nov 2017 19:44:49 +0800	[thread overview]
Message-ID: <201711221820.4HONikRo%fengguang.wu@intel.com> (raw)
In-Reply-To: <20171120104109.11585-1-otubo@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1946 bytes --]

Hi Eduardo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on xen-tip/linux-next]
[also build test ERROR on v4.14 next-20171121]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Eduardo-Otubo/xen-netfront-remove-warning-when-unloading-module/20171122-163844
base:   https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers//net/xen-netfront.c: In function 'xennet_remove':
>> drivers//net/xen-netfront.c:2139:12: error: 'struct xenbus_device' has no member named 'xenbus_state'
     while (dev->xenbus_state != XenbusStateClosed){
               ^~

vim +2139 drivers//net/xen-netfront.c

  2126	
  2127	static int xennet_remove(struct xenbus_device *dev)
  2128	{
  2129		struct netfront_info *info = dev_get_drvdata(&dev->dev);
  2130	
  2131		dev_dbg(&dev->dev, "%s\n", dev->nodename);
  2132	
  2133		xenbus_switch_state(dev, XenbusStateClosing);
  2134		while (xenbus_read_driver_state(dev->otherend) != XenbusStateClosing){
  2135			cpu_relax();
  2136			schedule();
  2137		}
  2138		xenbus_switch_state(dev, XenbusStateClosed);
> 2139		while (dev->xenbus_state != XenbusStateClosed){
  2140			cpu_relax();
  2141			schedule();
  2142		}
  2143	
  2144		xennet_disconnect_backend(info);
  2145	
  2146		unregister_netdev(info->netdev);
  2147	
  2148		if (info->queues)
  2149			xennet_destroy_queues(info);
  2150		xennet_free_netdev(info->netdev);
  2151	
  2152		return 0;
  2153	}
  2154	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 61719 bytes --]