From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/5] btrfs: Remove dead code
Date: Mon, 4 Dec 2017 14:45:21 +0100 [thread overview]
Message-ID: <20171204134521.GV3553@twin.jikos.cz> (raw)
In-Reply-To: <1512119984-12708-2-git-send-email-nborisov@suse.com>
On Fri, Dec 01, 2017 at 11:19:40AM +0200, Nikolay Borisov wrote:
> trans was statically assigned to NULL and this never changed over the course of
> btrfs_get_extent. So remove any code which checks whether trans != NULL and
> just hardcode the fact trans is always NULL. This fixes CID#112806
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Please find a better subject, at least mention the fuction name write
something more specific about the dead code that's being removed.
next prev parent reply other threads:[~2017-12-04 13:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 9:19 [PATCH 0/5] Misc cleanups Nikolay Borisov
2017-12-01 9:19 ` [PATCH 1/5] btrfs: Remove dead code Nikolay Borisov
2017-12-04 13:45 ` David Sterba [this message]
2017-12-05 11:53 ` [PATCH] btrfs: Remove dead code btrfs_get_extent Nikolay Borisov
2017-12-01 9:19 ` [PATCH 2/5] btrfs: Remove dead code Nikolay Borisov
2017-12-04 13:50 ` David Sterba
2017-12-04 16:17 ` Nikolay Borisov
2017-12-01 9:19 ` [PATCH 3/5] btrfs: Fix possible off-by-one in btrfs_search_path_in_tree Nikolay Borisov
2017-12-06 15:48 ` David Sterba
2017-12-01 9:19 ` [PATCH 4/5] btrfs: Remove redundant NULL check Nikolay Borisov
2017-12-06 16:02 ` David Sterba
2017-12-01 9:19 ` [PATCH 5/5] btrfs: Greatly simplify btrfs_read_dev_super Nikolay Borisov
2017-12-01 23:23 ` Anand Jain
2017-12-03 9:43 ` Nikolay Borisov
2017-12-04 1:33 ` Anand Jain
2017-12-04 14:13 ` David Sterba
2017-12-04 16:20 ` Nikolay Borisov
2017-12-06 16:24 ` David Sterba
[not found] ` <24281483-900c-ab1b-c407-5fa6983f5311@oracle.com>
2017-12-08 8:13 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204134521.GV3553@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.