From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Javier Martinez Canillas <javierm@redhat.com>,
linux-kernel@vger.kernel.org, James Ettle <james@ettle.org.uk>,
Azhar Shaikh <azhar.shaikh@intel.com>,
Arnd Bergmann <arnd@arndb.de>, Peter Huewe <peterhuewe@gmx.de>,
Jason Gunthorpe <jgg@ziepe.ca>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled
Date: Fri, 22 Dec 2017 20:39:30 +0200 [thread overview]
Message-ID: <20171222183930.kvdesz7pzhnhtztq@linux.intel.com> (raw)
In-Reply-To: <96f3f833-22f8-5400-bd22-7c1c622bbe61@redhat.com>
On Wed, Dec 20, 2017 at 12:43:39PM +0100, Hans de Goede wrote:
> Note I'm just reading along here, but I'm wondering if both the TPM
> and now also some PS/2 controllers need CLK_RUN to be disabled,
> why don't we just disable it once permanently and be done with it?
>
> It seems that on machines with a PS/2 controller connected to
> the LPC bus the BIOS is already doing this, so I've a feeling that
> it not being done on devices with a TPM is a bug in the firmware
> there and we should just disable it everywhere (and probably
> find a better place then the TPM driver to do the disabling).
>
> Note this is just an observation, I could be completely wrong here,
> but I've a feeling that just disabling CLKRUN all together is the
> right thing to do and that seems like an easier fix to me.
Agreed. Thanks for noting this. Right now, I would just apply TPM
driver specific fixes.
/Jarkko
next prev parent reply other threads:[~2017-12-22 18:39 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 11:35 [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled Javier Martinez Canillas
2017-12-20 11:35 ` [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O memory region Javier Martinez Canillas
2017-12-20 15:25 ` Shaikh, Azhar
2017-12-20 18:08 ` Jason Gunthorpe
2017-12-20 18:21 ` Javier Martinez Canillas
2017-12-20 18:54 ` Jason Gunthorpe
2017-12-20 19:15 ` Shaikh, Azhar
2017-12-21 12:48 ` Javier Martinez Canillas
2017-12-21 15:39 ` Shaikh, Azhar
2017-12-21 15:53 ` Javier Martinez Canillas
2017-12-21 16:34 ` Shaikh, Azhar
2017-12-22 18:35 ` Jarkko Sakkinen
2017-12-24 20:57 ` Jarkko Sakkinen
2017-12-20 11:35 ` [PATCH 2/4] tpm: delete the TPM_TIS_CLK_ENABLE flag Javier Martinez Canillas
2017-12-20 15:19 ` Shaikh, Azhar
2017-12-20 18:10 ` Jason Gunthorpe
2017-12-20 18:26 ` Javier Martinez Canillas
2017-12-22 18:38 ` Jarkko Sakkinen
2017-12-22 18:33 ` Jarkko Sakkinen
2017-12-20 11:35 ` [PATCH 3/4] tpm: follow coding style for variable declaration in tpm_tis_core_init() Javier Martinez Canillas
2017-12-22 18:32 ` Jarkko Sakkinen
2017-12-20 11:35 ` [PATCH 4/4] tpm: only attempt to disable the LPC CLKRUN if is already enabled Javier Martinez Canillas
2017-12-22 18:36 ` Jarkko Sakkinen
2017-12-20 11:43 ` [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled Hans de Goede
2017-12-20 12:12 ` Javier Martinez Canillas
2017-12-20 14:07 ` Alexander.Steffen
2017-12-20 14:35 ` Javier Martinez Canillas
2017-12-20 15:08 ` Shaikh, Azhar
2017-12-20 15:31 ` Javier Martinez Canillas
2017-12-20 15:41 ` Shaikh, Azhar
2017-12-20 16:45 ` Javier Martinez Canillas
2017-12-20 17:44 ` Jason Gunthorpe
2017-12-20 18:33 ` Javier Martinez Canillas
2017-12-22 18:39 ` Jarkko Sakkinen [this message]
2017-12-21 10:51 ` James Ettle
2017-12-21 12:46 ` Javier Martinez Canillas
2017-12-21 17:25 ` Jeffery Miller
2017-12-21 18:44 ` Javier Martinez Canillas
2017-12-21 19:02 ` Jeffery Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171222183930.kvdesz7pzhnhtztq@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=arnd@arndb.de \
--cc=azhar.shaikh@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=james@ettle.org.uk \
--cc=javierm@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.