From: Javier Martinez Canillas <javierm@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: James Ettle <james@ettle.org.uk>,
Hans de Goede <hdegoede@redhat.com>,
Azhar Shaikh <azhar.shaikh@intel.com>,
Javier Martinez Canillas <javierm@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Subject: [PATCH v2 0/3] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled
Date: Mon, 25 Dec 2017 03:22:48 +0100 [thread overview]
Message-ID: <20171225022251.6464-1-javierm@redhat.com> (raw)
Hello,
Commit 5e572cab92f0 ("tpm: Enable CLKRUN protocol for Braswell systems")
added logic in the TPM TIS driver to disable the Low Pin Count CLKRUN
signal during TPM transactions.
Unfortunately this breaks other devices that are attached to the LPC bus
like for example PS/2 mouse and keyboards.
The bug was reported to the Fedora kernel [0] and the kernel bugzilla [1].
This issue and the propossed solution were discussed in this [2] thread,
and the reporter (Jame Ettle) confirmed that his system works again after
the fix in this series.
The patches are based on top or Jarkko Sakkinen's linux-tpmdd [3] tree.
Changes since v1:
- Add collected tags
- Drop patch that fixed a bug in the error path since was already fixed.
[0]: https://bugzilla.redhat.com/show_bug.cgi?id=1498987
[1]: https://bugzilla.kernel.org/show_bug.cgi?id=197287
[2]: https://patchwork.kernel.org/patch/10119417/
[3]: git.infradead.org/users/jjs/linux-tpmdd.git
Best regards,
Javier
Javier Martinez Canillas (3):
tpm: delete the TPM_TIS_CLK_ENABLE flag
tpm: follow coding style for variable declaration in
tpm_tis_core_init()
tpm: only attempt to disable the LPC CLKRUN if is already enabled
drivers/char/tpm/tpm_tis.c | 15 ---------------
drivers/char/tpm/tpm_tis_core.c | 17 +++++++++++++----
drivers/char/tpm/tpm_tis_core.h | 1 -
3 files changed, 13 insertions(+), 20 deletions(-)
--
2.14.3
next reply other threads:[~2017-12-25 2:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-25 2:22 Javier Martinez Canillas [this message]
2017-12-25 2:22 ` [PATCH v2 1/3] tpm: delete the TPM_TIS_CLK_ENABLE flag Javier Martinez Canillas
2017-12-25 2:22 ` [PATCH v2 2/3] tpm: follow coding style for variable declaration in tpm_tis_core_init() Javier Martinez Canillas
2017-12-25 2:22 ` [PATCH v2 3/3] tpm: only attempt to disable the LPC CLKRUN if is already enabled Javier Martinez Canillas
2018-01-02 14:41 ` [PATCH v2 0/3] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171225022251.6464-1-javierm@redhat.com \
--to=javierm@redhat.com \
--cc=azhar.shaikh@intel.com \
--cc=hdegoede@redhat.com \
--cc=james@ettle.org.uk \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.