From: Steven Rostedt <rostedt@goodmis.org>
To: linux-trace-devel@vger.kernel.org
Subject: [PATCH 00/38] trace-cmd: Simplify the msg handling
Date: Wed, 03 Jan 2018 12:52:02 -0500 [thread overview]
Message-ID: <20180103175202.044283643@goodmis.org> (raw)
The msg handling of trace-cmd for the listen and record code is
overly complex due to the multiplexing functions. Rewrite the code
such that it is easier to understand. This will allow us to extend
it in the future for the virt-server work.
-- Steve
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git
trace-cmd
Head SHA1: 9420ffed51b5a1a28c175efc41fdd49507acda89
Steven Rostedt (Red Hat) (34):
trace-cmd: Remove the creating of msg out of tracecmd_msg_send()
trace-cmd: Move tracecmd_msg_send_and_wait_for_msg() into its only user
trace-cmd: Turn tracecmd_msg data into an anonymous union
trace-cmd: Remove unused structure tracecmd_msg_error
trace-cmd: Move size and cmd in tracecmd_msg into its own header struct
trace-cmd: Move the tracecmd_msg pointers into their own union
trace-cmd: Just use the buf field for sending pointers
trace-cmd: Use an array to map msg types and min sizes
trace-cmd: Merge msg_do_write_check() into msg_write()
trace-cmd: Simplify msg_free() by using min sizes
trace-cmd: Add tracecmd_msg_init() helper function
trace-cmd: Remove mulitplexer tracecmd_msg_create()
trace-cmd: Simplify msg_read_extra()
trace-cmd: Have msg_free() zero out msg contents
trace-cmd: Verify RINIT was received after TINIT msg sent
trace-cmd: Make send_metadata a flag in the output handle
trace-cmd: Pass cpu count and port array to make_rinit()
trace-cmd: Pass cpu_count instead of having it as a global
trace-cmd: Pass in client_ports instead of using a global variable
trace-cmd msg: Add debug prints of messages sent and received
trace-cmd msg: Move the saved closing fd to the caller
trace-cmd listen: Add better output on error of connections
trace-cmd msg: Create a msg_handle to pass around for saved state
trace-cmd msg: Add server structure of msg_handler
trace-cmd: Remove global use_tcp variable
trace-cmd: Move protocol version into msg_handler
tracecmd: Clean up handling of cpu_count
tracecmd listen: Have pagesize passed as return not parameter
trace-cmd: Have cpu_count reside in instances and not be global
trace-cmd: Add option CPUCOUNT to buffer instance options
trace-cmd: Have msg_handle part of the buffer instance
trace-cmd record: Allow instances to be recorded over the network
trace-cmd: Have keep and profile be flags of buffer instance
trace-cmd: Add network handle into buffer instance
Steven Rostedt (VMware) (4):
trace-cmd recorder: Check if pipe_size was modified by fcntl(F_GETPIPE_SZ)
pevent: Simplify pointer print logic and fix %pF
pevent: Handle new pointer processing of bprint strings
trace-cmd record: Fix clearing out the ctx->instance when used in for_all_instances()
----
event-parse.c | 43 ++++-
trace-cmd.h | 52 +++++-
trace-input.c | 27 ++++
trace-listen.c | 138 +++++++++++-----
trace-local.h | 15 +-
trace-msg.c | 486 ++++++++++++++++++++++++++++---------------------------
trace-msg.h | 10 --
trace-output.c | 38 ++++-
trace-record.c | 391 +++++++++++++++++++++++++++-----------------
trace-recorder.c | 7 +-
trace-stat.c | 2 +-
11 files changed, 741 insertions(+), 468 deletions(-)
next reply other threads:[~2018-01-03 17:53 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 17:52 Steven Rostedt [this message]
2018-01-03 17:52 ` [PATCH 01/38] trace-cmd recorder: Check if pipe_size was modified by fcntl(F_GETPIPE_SZ) Steven Rostedt
2018-01-03 17:52 ` [PATCH 02/38] pevent: Simplify pointer print logic and fix %pF Steven Rostedt
2018-01-03 17:52 ` [PATCH 03/38] pevent: Handle new pointer processing of bprint strings Steven Rostedt
2018-01-03 17:52 ` [PATCH 04/38] trace-cmd record: Fix clearing out the ctx->instance when used in for_all_instances() Steven Rostedt
2018-01-03 17:52 ` [PATCH 05/38] trace-cmd: Remove the creating of msg out of tracecmd_msg_send() Steven Rostedt
2018-01-03 17:52 ` [PATCH 06/38] trace-cmd: Move tracecmd_msg_send_and_wait_for_msg() into its only user Steven Rostedt
2018-01-03 17:52 ` [PATCH 07/38] trace-cmd: Turn tracecmd_msg data into an anonymous union Steven Rostedt
2018-01-03 17:52 ` [PATCH 08/38] trace-cmd: Remove unused structure tracecmd_msg_error Steven Rostedt
2018-01-03 17:52 ` [PATCH 09/38] trace-cmd: Move size and cmd in tracecmd_msg into its own header struct Steven Rostedt
2018-01-03 17:52 ` [PATCH 10/38] trace-cmd: Move the tracecmd_msg pointers into their own union Steven Rostedt
2018-01-03 17:52 ` [PATCH 11/38] trace-cmd: Just use the buf field for sending pointers Steven Rostedt
2018-01-03 17:52 ` [PATCH 12/38] trace-cmd: Use an array to map msg types and min sizes Steven Rostedt
2018-01-03 17:52 ` [PATCH 13/38] trace-cmd: Merge msg_do_write_check() into msg_write() Steven Rostedt
2018-01-03 17:52 ` [PATCH 14/38] trace-cmd: Simplify msg_free() by using min sizes Steven Rostedt
2018-01-03 17:52 ` [PATCH 15/38] trace-cmd: Add tracecmd_msg_init() helper function Steven Rostedt
2018-01-03 17:52 ` [PATCH 16/38] trace-cmd: Remove mulitplexer tracecmd_msg_create() Steven Rostedt
2018-01-03 17:52 ` [PATCH 17/38] trace-cmd: Simplify msg_read_extra() Steven Rostedt
2018-01-03 17:52 ` [PATCH 18/38] trace-cmd: Have msg_free() zero out msg contents Steven Rostedt
2018-01-03 17:52 ` [PATCH 19/38] trace-cmd: Verify RINIT was received after TINIT msg sent Steven Rostedt
2018-01-03 17:52 ` [PATCH 20/38] trace-cmd: Make send_metadata a flag in the output handle Steven Rostedt
2018-01-03 17:52 ` [PATCH 21/38] trace-cmd: Pass cpu count and port array to make_rinit() Steven Rostedt
2018-01-03 17:52 ` [PATCH 22/38] trace-cmd: Pass cpu_count instead of having it as a global Steven Rostedt
2018-01-03 17:52 ` [PATCH 23/38] trace-cmd: Pass in client_ports instead of using a global variable Steven Rostedt
2018-01-03 17:52 ` [PATCH 24/38] trace-cmd msg: Add debug prints of messages sent and received Steven Rostedt
2018-01-03 17:52 ` [PATCH 25/38] trace-cmd msg: Move the saved closing fd to the caller Steven Rostedt
2018-01-03 17:52 ` [PATCH 26/38] trace-cmd listen: Add better output on error of connections Steven Rostedt
2018-01-03 17:52 ` [PATCH 27/38] trace-cmd msg: Create a msg_handle to pass around for saved state Steven Rostedt
2018-01-03 17:52 ` [PATCH 28/38] trace-cmd msg: Add server structure of msg_handler Steven Rostedt
2018-01-03 20:31 ` [PATCH 28/38 v2] " Steven Rostedt
2018-01-03 17:52 ` [PATCH 29/38] trace-cmd: Remove global use_tcp variable Steven Rostedt
2018-01-03 17:52 ` [PATCH 30/38] trace-cmd: Move protocol version into msg_handler Steven Rostedt
2018-01-03 17:52 ` [PATCH 31/38] tracecmd: Clean up handling of cpu_count Steven Rostedt
2018-01-03 17:52 ` [PATCH 32/38] tracecmd listen: Have pagesize passed as return not parameter Steven Rostedt
2018-01-03 17:52 ` [PATCH 33/38] trace-cmd: Have cpu_count reside in instances and not be global Steven Rostedt
2018-01-03 17:52 ` [PATCH 34/38] trace-cmd: Add option CPUCOUNT to buffer instance options Steven Rostedt
2018-01-03 17:52 ` [PATCH 35/38] trace-cmd: Have msg_handle part of the buffer instance Steven Rostedt
2018-01-03 17:52 ` [PATCH 36/38] trace-cmd record: Allow instances to be recorded over the network Steven Rostedt
2018-01-03 17:52 ` [PATCH 37/38] trace-cmd: Have keep and profile be flags of buffer instance Steven Rostedt
2018-01-03 17:52 ` [PATCH 38/38] trace-cmd: Add network handle into " Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103175202.044283643@goodmis.org \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.