All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
To: <linux-btrfs@vger.kernel.org>
Subject: [PATCH 00/67] btrfs-progs: add the stack prefix for the set/get
Date: Thu, 11 Jan 2018 13:08:32 +0800	[thread overview]
Message-ID: <20180111050939.21251-1-lufq.fnst@cn.fujitsu.com> (raw)

These set/get functions defined by BTRFS_SETGET_STACK_FUNCS macro is
missing the prefix stack. I can't add an extent buffer version set/get
function as the result of the function name conflict.

To settle a matter once and for all, I have written a script to rename
these functions. And, I will attach this script generated this patchset to
make review easier. At the beginning I forget renaming these functions will
bring on a ton of warning like "WARNING: line over 80 characters".
Consequently, you know I have to split those lines manually. This step is
too boring and stupid.

I'm not sure how to split this patchset appropriately. If this bunch of
patches is annoying, I'm OK with squashing these patches. At last, If this
btrfs-progs version patchset is acceptable, I can send the kernel version
as well.

#!/bin/bash
funcs=$(grep -oP '(?<=^BTRFS_SETGET_STACK_FUNCS\()(?!stack)\w+(?=,)' ctree.h)

for func in ${funcs}; do
	echo $func
	files=$(grep -PIRwl 'btrfs_(set_)?'${func})
	sed -i 's/'"\(btrfs_\(set_\)\?\)\(${func}(\)"'/\1stack_\3/g' ${files}
	sed -i 's/'"^\(BTRFS_SETGET_STACK_FUNCS(\)\(${func},\)"'/\1stack_\2/g' ctree.h
	if ! make; then
		break;
	fi
	git commit -as -F <(cat <<EOF
btrfs-progs: add the stack prefix for ${func} set/get function

The ${func} set/get function defined by
BTRFS_SETGET_STACK_FUNCS macro is missing the prefix stack.
EOF
)
done

Lu Fengqi (67):
  btrfs-progs: add the stack prefix for block_group_used set/get
    function
  btrfs-progs: add the stack prefix for block_group_chunk_objectid
    set/get function
  btrfs-progs: add the stack prefix for block_group_flags set/get
    function
  btrfs-progs: add the stack prefix for disk_key_objectid set/get
    function
  btrfs-progs: add the stack prefix for disk_key_offset set/get function
  btrfs-progs: add the stack prefix for disk_key_type set/get function
  btrfs-progs: add the stack prefix for root_generation set/get function
  btrfs-progs: add the stack prefix for root_bytenr set/get function
  btrfs-progs: add the stack prefix for root_level set/get function
  btrfs-progs: add the stack prefix for root_dirid set/get function
  btrfs-progs: add the stack prefix for root_refs set/get function
  btrfs-progs: add the stack prefix for root_flags set/get function
  btrfs-progs: add the stack prefix for root_used set/get function
  btrfs-progs: add the stack prefix for root_limit set/get function
  btrfs-progs: add the stack prefix for root_last_snapshot set/get
    function
  btrfs-progs: add the stack prefix for root_generation_v2 set/get
    function
  btrfs-progs: add the stack prefix for root_ctransid set/get function
  btrfs-progs: add the stack prefix for root_otransid set/get function
  btrfs-progs: add the stack prefix for root_stransid set/get function
  btrfs-progs: add the stack prefix for root_rtransid set/get function
  btrfs-progs: add the stack prefix for backup_tree_root set/get
    function
  btrfs-progs: add the stack prefix for backup_tree_root_gen set/get
    function
  btrfs-progs: add the stack prefix for backup_tree_root_level set/get
    function
  btrfs-progs: add the stack prefix for backup_chunk_root set/get
    function
  btrfs-progs: add the stack prefix for backup_chunk_root_gen set/get
    function
  btrfs-progs: add the stack prefix for backup_chunk_root_level set/get
    function
  btrfs-progs: add the stack prefix for backup_extent_root set/get
    function
  btrfs-progs: add the stack prefix for backup_extent_root_gen set/get
    function
  btrfs-progs: add the stack prefix for backup_extent_root_level set/get
    function
  btrfs-progs: add the stack prefix for backup_fs_root set/get function
  btrfs-progs: add the stack prefix for backup_fs_root_gen set/get
    function
  btrfs-progs: add the stack prefix for backup_fs_root_level set/get
    function
  btrfs-progs: add the stack prefix for backup_dev_root set/get function
  btrfs-progs: add the stack prefix for backup_dev_root_gen set/get
    function
  btrfs-progs: add the stack prefix for backup_dev_root_level set/get
    function
  btrfs-progs: add the stack prefix for backup_csum_root set/get
    function
  btrfs-progs: add the stack prefix for backup_csum_root_gen set/get
    function
  btrfs-progs: add the stack prefix for backup_csum_root_level set/get
    function
  btrfs-progs: add the stack prefix for backup_total_bytes set/get
    function
  btrfs-progs: add the stack prefix for backup_bytes_used set/get
    function
  btrfs-progs: add the stack prefix for backup_num_devices set/get
    function
  btrfs-progs: add the stack prefix for super_bytenr set/get function
  btrfs-progs: add the stack prefix for super_flags set/get function
  btrfs-progs: add the stack prefix for super_generation set/get
    function
  btrfs-progs: add the stack prefix for super_root set/get function
  btrfs-progs: add the stack prefix for super_sys_array_size set/get
    function
  btrfs-progs: add the stack prefix for super_chunk_root_generation
    set/get function
  btrfs-progs: add the stack prefix for super_root_level set/get
    function
  btrfs-progs: add the stack prefix for super_chunk_root set/get
    function
  btrfs-progs: add the stack prefix for super_chunk_root_level set/get
    function
  btrfs-progs: add the stack prefix for super_log_root set/get function
  btrfs-progs: add the stack prefix for super_log_root_transid set/get
    function
  btrfs-progs: add the stack prefix for super_log_root_level set/get
    function
  btrfs-progs: add the stack prefix for super_total_bytes set/get
    function
  btrfs-progs: add the stack prefix for super_bytes_used set/get
    function
  btrfs-progs: add the stack prefix for super_sectorsize set/get
    function
  btrfs-progs: add the stack prefix for super_nodesize set/get function
  btrfs-progs: add the stack prefix for super_stripesize set/get
    function
  btrfs-progs: add the stack prefix for super_root_dir set/get function
  btrfs-progs: add the stack prefix for super_num_devices set/get
    function
  btrfs-progs: add the stack prefix for super_compat_flags set/get
    function
  btrfs-progs: add the stack prefix for super_compat_ro_flags set/get
    function
  btrfs-progs: add the stack prefix for super_incompat_flags set/get
    function
  btrfs-progs: add the stack prefix for super_csum_type set/get function
  btrfs-progs: add the stack prefix for super_cache_generation set/get
    function
  btrfs-progs: add the stack prefix for super_uuid_tree_generation
    set/get function
  btrfs-progs: add the stack prefix for super_magic set/get function

 backref.c                 |   2 +-
 btrfs-find-root.c         |  14 ++--
 btrfs-fragments.c         |   4 +-
 btrfs-list.c              |  10 +--
 btrfs-zero-log.c          |   8 +--
 btrfstune.c               |  18 ++---
 chunk-recover.c           |  37 ++++++-----
 cmds-check.c              | 111 ++++++++++++++++---------------
 cmds-inspect-dump-super.c | 105 ++++++++++++++---------------
 cmds-inspect-dump-tree.c  |  37 ++++++-----
 cmds-rescue.c             |   8 +--
 cmds-restore.c            |   9 +--
 convert/common.c          |  98 +++++++++++++--------------
 convert/main.c            |  20 +++---
 ctree.c                   |  12 ++--
 ctree.h                   | 150 ++++++++++++++++++++++-------------------
 dir-test.c                |   6 +-
 disk-io.c                 | 166 ++++++++++++++++++++++++----------------------
 extent-tree.c             |  49 +++++++-------
 find-root.c               |   2 +-
 free-space-cache.c        |   4 +-
 free-space-tree.c         |   4 +-
 image/main.c              |  39 +++++------
 inode.c                   |   2 +-
 mkfs/common.c             |  83 ++++++++++++-----------
 mkfs/main.c               |  17 ++---
 print-tree.c              |  46 ++++++-------
 qgroup-verify.c           |   2 +-
 random-test.c             |   4 +-
 root-tree.c               |   6 +-
 send-utils.c              |  23 ++++---
 super-recover.c           |   4 +-
 transaction.c             |  10 +--
 utils.c                   |  20 +++---
 volumes.c                 |  39 ++++++-----
 35 files changed, 610 insertions(+), 559 deletions(-)

-- 
2.15.1




             reply	other threads:[~2018-01-11  5:09 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-11  5:08 Lu Fengqi [this message]
2018-01-11  5:08 ` [PATCH 01/67] btrfs-progs: add the stack prefix for block_group_used set/get function Lu Fengqi
2018-01-11  5:08 ` [PATCH 02/67] btrfs-progs: add the stack prefix for block_group_chunk_objectid " Lu Fengqi
2018-01-11  5:08 ` [PATCH 03/67] btrfs-progs: add the stack prefix for block_group_flags " Lu Fengqi
2018-01-11  5:08 ` [PATCH 04/67] btrfs-progs: add the stack prefix for disk_key_objectid " Lu Fengqi
2018-01-11  5:08 ` [PATCH 05/67] btrfs-progs: add the stack prefix for disk_key_offset " Lu Fengqi
2018-01-11  5:08 ` [PATCH 06/67] btrfs-progs: add the stack prefix for disk_key_type " Lu Fengqi
2018-01-11  5:08 ` [PATCH 07/67] btrfs-progs: add the stack prefix for root_generation " Lu Fengqi
2018-01-11  5:08 ` [PATCH 08/67] btrfs-progs: add the stack prefix for root_bytenr " Lu Fengqi
2018-01-11  5:08 ` [PATCH 09/67] btrfs-progs: add the stack prefix for root_level " Lu Fengqi
2018-01-11  5:08 ` [PATCH 10/67] btrfs-progs: add the stack prefix for root_dirid " Lu Fengqi
2018-01-11  5:08 ` [PATCH 11/67] btrfs-progs: add the stack prefix for root_refs " Lu Fengqi
2018-01-11  5:08 ` [PATCH 12/67] btrfs-progs: add the stack prefix for root_flags " Lu Fengqi
2018-01-11  5:08 ` [PATCH 13/67] btrfs-progs: add the stack prefix for root_used " Lu Fengqi
2018-01-11  5:08 ` [PATCH 14/67] btrfs-progs: add the stack prefix for root_limit " Lu Fengqi
2018-01-11  5:08 ` [PATCH 15/67] btrfs-progs: add the stack prefix for root_last_snapshot " Lu Fengqi
2018-01-11  5:08 ` [PATCH 16/67] btrfs-progs: add the stack prefix for root_generation_v2 " Lu Fengqi
2018-01-11  5:08 ` [PATCH 17/67] btrfs-progs: add the stack prefix for root_ctransid " Lu Fengqi
2018-01-11  5:08 ` [PATCH 18/67] btrfs-progs: add the stack prefix for root_otransid " Lu Fengqi
2018-01-11  5:08 ` [PATCH 19/67] btrfs-progs: add the stack prefix for root_stransid " Lu Fengqi
2018-01-11  5:08 ` [PATCH 20/67] btrfs-progs: add the stack prefix for root_rtransid " Lu Fengqi
2018-01-11  5:08 ` [PATCH 21/67] btrfs-progs: add the stack prefix for backup_tree_root " Lu Fengqi
2018-01-11  5:08 ` [PATCH 22/67] btrfs-progs: add the stack prefix for backup_tree_root_gen " Lu Fengqi
2018-01-11  5:08 ` [PATCH 23/67] btrfs-progs: add the stack prefix for backup_tree_root_level " Lu Fengqi
2018-01-11  5:08 ` [PATCH 24/67] btrfs-progs: add the stack prefix for backup_chunk_root " Lu Fengqi
2018-01-11  5:08 ` [PATCH 25/67] btrfs-progs: add the stack prefix for backup_chunk_root_gen " Lu Fengqi
2018-01-11  5:08 ` [PATCH 26/67] btrfs-progs: add the stack prefix for backup_chunk_root_level " Lu Fengqi
2018-01-11  5:08 ` [PATCH 27/67] btrfs-progs: add the stack prefix for backup_extent_root " Lu Fengqi
2018-01-11  5:09 ` [PATCH 28/67] btrfs-progs: add the stack prefix for backup_extent_root_gen " Lu Fengqi
2018-01-11  5:09 ` [PATCH 29/67] btrfs-progs: add the stack prefix for backup_extent_root_level " Lu Fengqi
2018-01-11  5:09 ` [PATCH 30/67] btrfs-progs: add the stack prefix for backup_fs_root " Lu Fengqi
2018-01-11  5:09 ` [PATCH 31/67] btrfs-progs: add the stack prefix for backup_fs_root_gen " Lu Fengqi
2018-01-11  5:09 ` [PATCH 32/67] btrfs-progs: add the stack prefix for backup_fs_root_level " Lu Fengqi
2018-01-11  5:09 ` [PATCH 33/67] btrfs-progs: add the stack prefix for backup_dev_root " Lu Fengqi
2018-01-11  5:09 ` [PATCH 34/67] btrfs-progs: add the stack prefix for backup_dev_root_gen " Lu Fengqi
2018-01-11  5:09 ` [PATCH 35/67] btrfs-progs: add the stack prefix for backup_dev_root_level " Lu Fengqi
2018-01-11  5:09 ` [PATCH 36/67] btrfs-progs: add the stack prefix for backup_csum_root " Lu Fengqi
2018-01-11  5:09 ` [PATCH 37/67] btrfs-progs: add the stack prefix for backup_csum_root_gen " Lu Fengqi
2018-01-11  5:09 ` [PATCH 38/67] btrfs-progs: add the stack prefix for backup_csum_root_level " Lu Fengqi
2018-01-11  5:09 ` [PATCH 39/67] btrfs-progs: add the stack prefix for backup_total_bytes " Lu Fengqi
2018-01-11  5:09 ` [PATCH 40/67] btrfs-progs: add the stack prefix for backup_bytes_used " Lu Fengqi
2018-01-11  5:09 ` [PATCH 41/67] btrfs-progs: add the stack prefix for backup_num_devices " Lu Fengqi
2018-01-11  5:09 ` [PATCH 42/67] btrfs-progs: add the stack prefix for super_bytenr " Lu Fengqi
2018-01-11  5:09 ` [PATCH 43/67] btrfs-progs: add the stack prefix for super_flags " Lu Fengqi
2018-01-11  5:09 ` [PATCH 44/67] btrfs-progs: add the stack prefix for super_generation " Lu Fengqi
2018-01-11  5:09 ` [PATCH 45/67] btrfs-progs: add the stack prefix for super_root " Lu Fengqi
2018-01-11  5:09 ` [PATCH 46/67] btrfs-progs: add the stack prefix for super_sys_array_size " Lu Fengqi
2018-01-11  5:09 ` [PATCH 47/67] btrfs-progs: add the stack prefix for super_chunk_root_generation " Lu Fengqi
2018-01-11  5:09 ` [PATCH 48/67] btrfs-progs: add the stack prefix for super_root_level " Lu Fengqi
2018-01-11  5:09 ` [PATCH 49/67] btrfs-progs: add the stack prefix for super_chunk_root " Lu Fengqi
2018-01-11  5:09 ` [PATCH 50/67] btrfs-progs: add the stack prefix for super_chunk_root_level " Lu Fengqi
2018-01-11  5:09 ` [PATCH 51/67] btrfs-progs: add the stack prefix for super_log_root " Lu Fengqi
2018-01-11  5:09 ` [PATCH 52/67] btrfs-progs: add the stack prefix for super_log_root_transid " Lu Fengqi
2018-01-11  5:09 ` [PATCH 53/67] btrfs-progs: add the stack prefix for super_log_root_level " Lu Fengqi
2018-01-11  5:09 ` [PATCH 54/67] btrfs-progs: add the stack prefix for super_total_bytes " Lu Fengqi
2018-01-11  5:09 ` [PATCH 55/67] btrfs-progs: add the stack prefix for super_bytes_used " Lu Fengqi
2018-01-11  5:09 ` [PATCH 56/67] btrfs-progs: add the stack prefix for super_sectorsize " Lu Fengqi
2018-01-11  5:09 ` [PATCH 57/67] btrfs-progs: add the stack prefix for super_nodesize " Lu Fengqi
2018-01-11  5:09 ` [PATCH 58/67] btrfs-progs: add the stack prefix for super_stripesize " Lu Fengqi
2018-01-11  5:09 ` [PATCH 59/67] btrfs-progs: add the stack prefix for super_root_dir " Lu Fengqi
2018-01-11  5:09 ` [PATCH 60/67] btrfs-progs: add the stack prefix for super_num_devices " Lu Fengqi
2018-01-11  5:09 ` [PATCH 61/67] btrfs-progs: add the stack prefix for super_compat_flags " Lu Fengqi
2018-01-11  5:09 ` [PATCH 62/67] btrfs-progs: add the stack prefix for super_compat_ro_flags " Lu Fengqi
2018-01-11  5:09 ` [PATCH 63/67] btrfs-progs: add the stack prefix for super_incompat_flags " Lu Fengqi
2018-01-11  5:09 ` [PATCH 64/67] btrfs-progs: add the stack prefix for super_csum_type " Lu Fengqi
2018-01-11  5:09 ` [PATCH 65/67] btrfs-progs: add the stack prefix for super_cache_generation " Lu Fengqi
2018-01-11  5:09 ` [PATCH 66/67] btrfs-progs: add the stack prefix for super_uuid_tree_generation " Lu Fengqi
2018-01-11  5:09 ` [PATCH 67/67] btrfs-progs: add the stack prefix for super_magic " Lu Fengqi
2018-01-23 14:29 ` [PATCH 00/67] btrfs-progs: add the stack prefix for the set/get David Sterba
2018-01-24  6:44   ` Lu Fengqi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180111050939.21251-1-lufq.fnst@cn.fujitsu.com \
    --to=lufq.fnst@cn.fujitsu.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.