From: Eryu Guan <eguan@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH v2 0/7] Overlayfs exportfs tests
Date: Wed, 24 Jan 2018 18:40:23 +0800 [thread overview]
Message-ID: <20180124104023.GB18267@eguan.usersys.redhat.com> (raw)
In-Reply-To: <1516741152-20345-1-git-send-email-amir73il@gmail.com>
On Tue, Jan 23, 2018 at 10:59:05PM +0200, Amir Goldstein wrote:
> Eryu,
>
> This is the 2nd revision of test for overlayfs NFS export.
>
> Changes since v1:
> - Added new generic/exportfs test instead of changing existing test
> - Addressed review comments on open_by_handle [-i|-o] patch
> - Added the test that uses open_by_handle [-i|-o] in the same patch
> - Split new overlay/exportfs tests to four tests, a pair of tests
> for samefs and a pair of tests for non-samefs configuration.
> - For each configuration, one test requires and enables redirect_dir
> for directory rename test cases and both tests require and enable
> nfs_export feature.
>
> The new overlay tests don't run on upstream kernel and pass with
> my overlayfs NFS export V3 branch [1]. You may want to wait with
> merging those tests until overlayfs NFS support is merged.
Yeah, I probably will wait and let the kernel patches go first. (And
I'll go through the overlay specific patches later.)
>
> Merging patches 1-3 seems like a good idea to me regardless of
> overlayfs NFS export support.
Patches 1-3 look good to me. One minor issue is that my compiler
complained about "may be used uninitialized" on 'infile' and 'outfile'
open_by_handle.c:350:12: warning: 'outfile' may be used uninitialized in this function [-Wmaybe-uninitialized]
though I don't think we'll use them uninitialized in practice, I'd like
to initialize them with NULL on commit.
Thanks for the revision!
Eryu
next prev parent reply other threads:[~2018-01-24 10:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 20:59 [PATCH v2 0/7] Overlayfs exportfs tests Amir Goldstein
2018-01-23 20:59 ` [PATCH v2 1/7] open_by_handle: verify dir content only with -r flag Amir Goldstein
2018-01-23 20:59 ` [PATCH v2 2/7] generic/exportfs: golden output is not silent Amir Goldstein
2018-01-23 20:59 ` [PATCH v2 3/7] generic/exportfs: test decoding file handles after cycle mount Amir Goldstein
2018-01-23 20:59 ` [PATCH v2 4/7] overlay: test encode/decode overlay file handles Amir Goldstein
2018-01-23 20:59 ` [PATCH v2 5/7] overlay: test encode/decode of non-samefs " Amir Goldstein
2018-01-24 16:36 ` Amir Goldstein
2018-01-23 20:59 ` [PATCH v2 6/7] overlay: test encode/decode overlay file handles with renames Amir Goldstein
2018-01-23 20:59 ` [PATCH v2 7/7] overlay: test encode/decode of non-samefs " Amir Goldstein
2018-01-24 16:40 ` Amir Goldstein
2018-01-24 10:40 ` Eryu Guan [this message]
2018-01-24 10:48 ` [PATCH v2 0/7] Overlayfs exportfs tests Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124104023.GB18267@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=amir73il@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.