From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 0/3] Usb 20180125 patches
Date: Thu, 25 Jan 2018 17:24:50 +0100 [thread overview]
Message-ID: <20180125162450.4dguzk5ifvo3njcb@sirius.home.kraxel.org> (raw)
In-Reply-To: <CAFEAcA_U7Dw4m+wLeqHRij5YUO9eFkkpwwRjTWKr099Ux12+cw@mail.gmail.com>
On Thu, Jan 25, 2018 at 03:28:38PM +0000, Peter Maydell wrote:
> On 25 January 2018 at 09:16, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > Thomas Huth (1):
> > usb: Remove legacy -usbdevice options (host, serial, disk and net)
>
> Hi. This fails to build on FreeBSD:
>
> LINK arm-softmmu/qemu-system-arm
> ../vl.o: In function `usb_device_add':
> /root/qemu/vl.c:1471: undefined reference to `usb_host_device_open'
>
> There's still a call to that function in vl.c inside an
> ifndef CONFIG_LINUX...
>
> If we can really remove the function we should get rid of the
> stub in hw/usb/host-stub.c and the prototype in usb.h too.
Indeed. I'll fix it up.
The lines in vl.c dead code anyway since we switched to libusb and
dropped the linux/bsd specific usb-host code, so it all can simply be
deleted.
cheers,
Gerd
prev parent reply other threads:[~2018-01-25 16:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 9:16 [Qemu-devel] [PULL 0/3] Usb 20180125 patches Gerd Hoffmann
2018-01-25 9:16 ` [Qemu-devel] [PULL 1/3] usb: Remove legacy -usbdevice options (host, serial, disk and net) Gerd Hoffmann
2018-01-25 9:16 ` [Qemu-devel] [PULL 2/3] hw/usb/ccid: Make ccid_card_init() take an error parameter Gerd Hoffmann
2018-01-25 16:45 ` Philippe Mathieu-Daudé
2018-01-25 16:50 ` Philippe Mathieu-Daudé
2018-01-25 9:16 ` [Qemu-devel] [PULL 3/3] usb-storage: Fix share-rw option parsing Gerd Hoffmann
2018-01-25 15:28 ` [Qemu-devel] [PULL 0/3] Usb 20180125 patches Peter Maydell
2018-01-25 16:24 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180125162450.4dguzk5ifvo3njcb@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.