From: Eric Engestrom <eric.engestrom@imgtec.com>
To: dri-devel@lists.freedesktop.org
Subject: [PATCH libdrm 5/7] tests/util: fix signed/unsigned comparisons
Date: Fri, 26 Jan 2018 11:32:42 +0000 [thread overview]
Message-ID: <20180126113244.26946-5-eric.engestrom@imgtec.com> (raw)
In-Reply-To: <20180126113244.26946-1-eric.engestrom@imgtec.com>
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
tests/util/pattern.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tests/util/pattern.c b/tests/util/pattern.c
index 00b08a8cb8ebbd4e25f8..095eadf2fa459638c134 100644
--- a/tests/util/pattern.c
+++ b/tests/util/pattern.c
@@ -549,7 +549,6 @@ static void make_pwetty(void *data, unsigned int width, unsigned int height,
#ifdef HAVE_CAIRO
cairo_surface_t *surface;
cairo_t *cr;
- int x, y;
cairo_format_t cairo_format;
/* we can ignore the order of R,G,B channels */
@@ -576,8 +575,8 @@ static void make_pwetty(void *data, unsigned int width, unsigned int height,
cairo_surface_destroy(surface);
cairo_set_line_cap(cr, CAIRO_LINE_CAP_SQUARE);
- for (x = 0; x < width; x += 250)
- for (y = 0; y < height; y += 250) {
+ for (unsigned x = 0; x < width; x += 250)
+ for (unsigned y = 0; y < height; y += 250) {
char buf[64];
cairo_move_to(cr, x, y - 20);
--
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-01-26 11:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 11:32 [PATCH libdrm 1/7] remove unnecessary empty statements Eric Engestrom
2018-01-26 11:32 ` [PATCH libdrm 2/7] tests/amdgpu: add parentheses to make operation priority explicit Eric Engestrom
2018-01-26 13:26 ` Andrey Grodzovsky
2018-01-26 16:50 ` Eric Engestrom
2018-01-26 11:32 ` [PATCH libdrm 3/7] tests/amdgpu: drop unused variables Eric Engestrom
2018-01-26 11:32 ` [PATCH libdrm 4/7] tests/amdgpu: fix bad sign comparisons Eric Engestrom
2018-01-26 11:38 ` Christian König
2018-01-26 17:15 ` Eric Engestrom
2018-01-26 17:17 ` Christian König
2018-01-26 11:32 ` Eric Engestrom [this message]
2018-01-26 11:32 ` [PATCH libdrm 6/7] tests/util: drop unused parameters Eric Engestrom
2018-01-26 11:32 ` [PATCH libdrm 7/7] tests/etnaviv: drop unused `return 0` Eric Engestrom
2018-01-26 11:35 ` [PATCH libdrm 1/7] remove unnecessary empty statements Christian König
2018-01-26 17:44 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180126113244.26946-5-eric.engestrom@imgtec.com \
--to=eric.engestrom@imgtec.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.