From: Simon Horman <horms@verge.net.au>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Magnus Damm <magnus.damm@gmail.com>,
linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 2/3] mmc: tmio: add eMMC HS400 mode support
Date: Tue, 13 Feb 2018 12:33:53 +0100 [thread overview]
Message-ID: <20180213113353.tioy73y2ggsat7m3@verge.net.au> (raw)
In-Reply-To: <20180207222012.5hxmo2sdelur4uoj@ninjato>
On Wed, Feb 07, 2018 at 11:20:12PM +0100, Wolfram Sang wrote:
>
> Hi Simon,
>
> > + void (*disable_scc)(struct mmc_host *mmc);
>
> Do we really need this callback? I'd think it can be folded into
> reset_hs400_mode() because it is called only once?
>
> > + void (*prepare_hs400_tuning)(struct mmc_host *mmc, struct mmc_ios *ios);
>
> Can't we use the host->ops->prepare_hs400_tuning() callback invoked by
> the core?
Empirically that does not seem to work.
> > + void (*reset_hs400_mode)(struct mmc_host *mmc);
>
> Maybe we can get rid of this, too? See later...
>
> > + if (host->disable_scc)
> > + host->disable_scc(mmc);
>
> (Here, this can be folded into the next callback)
Yes, agreed. I've folded the callbacks as you suggest.
> > +
> > + /* reset HS400 mode */
> > + if (ios->timing != MMC_TIMING_MMC_HS400 && host->reset_hs400_mode)
> > + host->reset_hs400_mode(mmc);
>
> I wonder: If for any ios which is != MMC_TIMING_MMC_HS400, the
> hs400_mode needs to be reset. Couldn't we as well then disable the mode
> always after the MMC_TIMING_MMC_HS400 tuning was selected? Just
> brainstorming here...
Perhaps but I'm unsure where we would hook in this change, any ideas?
next prev parent reply other threads:[~2018-02-13 11:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 13:39 [PATCH v2 0/3] mmc: renesas_sdhi: add eMMC HS400 mode support Simon Horman
2018-01-19 13:39 ` [PATCH v2 1/3] mmc: tmio: correct treatment of errors during tuning Simon Horman
2018-02-07 21:52 ` Wolfram Sang
2018-02-13 11:31 ` Simon Horman
2018-02-13 12:55 ` Wolfram Sang
2018-01-19 13:39 ` [PATCH v2 2/3] mmc: tmio: add eMMC HS400 mode support Simon Horman
2018-02-07 22:20 ` Wolfram Sang
2018-02-13 11:33 ` Simon Horman [this message]
2018-02-13 13:00 ` Wolfram Sang
2018-01-19 13:39 ` [PATCH v2 3/3] mmc: renesas_sdhi: " Simon Horman
2018-02-07 22:21 ` Wolfram Sang
2018-02-13 11:38 ` Simon Horman
2018-02-13 13:01 ` Wolfram Sang
2018-02-07 22:26 ` [PATCH v2 0/3] " Wolfram Sang
2018-02-08 11:37 ` Simon Horman
2018-02-13 11:47 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213113353.tioy73y2ggsat7m3@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.