Re: [PATCH 2/2] kbuild: rename built-in.o to built-in.a

From: Sam Ravnborg <sam@ravnborg.org>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: linux-kbuild@vger.kernel.org,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michal Marek <michal.lkml@markovi.net>
Subject: Re: [PATCH 2/2] kbuild: rename built-in.o to built-in.a
Date: Sun, 18 Feb 2018 18:10:05 +0100	[thread overview]
Message-ID: <20180218171005.GA20286@ravnborg.org> (raw)
In-Reply-To: <20180210142504.29890-3-npiggin@gmail.com>

Hi Nicholas.

On Sun, Feb 11, 2018 at 12:25:04AM +1000, Nicholas Piggin wrote:
> Incremental linking is gone, so rename built-in.o to built-in.a, which
> is the usual extension for archive files.
> 
> This patch does two things, first is a simple search/replace:
> 
> git grep -l 'built-in\.o' | xargs sed -i 's/built-in\.o/built-in\.a/g'
> 
> The second is to invert nesting of nested text manipulations to avoid
> filtering built-in.a out from libs-y2:
> 
> -libs-y2 := $(filter-out %.a, $(patsubst %/, %/built-in.a, $(libs-y)))
> +libs-y2 := $(patsubst %/, %/built-in.a, $(filter-out %.a, $(libs-y)))
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>

Renaming is welcome - .o files should not list files.
Acked-by: Sam Ravnborg <sam@ravnborg.org>

Did you check that make clean / make mrproper continue to
do the right thing?

I recalled we had "*.o" hardcoded somewhere but grep
did not reveal any places that should matter.
So likely it does.

	Sam