From: Mark Brown <broonie@kernel.org>
To: Akshu Agrawal <akshu.agrawal@amd.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, lgirdwood@gmail.com
Subject: Re: [PATCH 1/2] ASoC: AMD: Use single dai for da7219 playback and capture
Date: Mon, 12 Mar 2018 10:01:18 -0700 [thread overview]
Message-ID: <20180312170118.GL2186@sirena.org.uk> (raw)
In-Reply-To: <1520845883-24062-1-git-send-email-akshu.agrawal@amd.com>
[-- Attachment #1.1: Type: text/plain, Size: 715 bytes --]
On Mon, Mar 12, 2018 at 02:41:22PM +0530, Akshu Agrawal wrote:
> BT I2S is a bi-directional dai, we will use the same
> cpu dai for playback and capture.
>
> TEST=Build, apply grunt_mixer_settings:
> iotools mmio_write32 0xfed80e40 0x040c40c0
> iotools mmio_write32 0xfed80e28 0x10000
> aplay -D hw:0,0 -vv <file>
> arecord -D hw:0,0 -f dat -d 5 -vv <file>
These reproduction instructions don't make much sense outside of your
test environment (how is anyone supposed to know what
grunt_mixer_settings is?). I'm also rather worried about the random
magic numbers you're using with this iowrite tool - what do they do? It
sounds like this driver might not work at all without some missing
bit...
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2018-03-12 17:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 9:11 [PATCH 1/2] ASoC: AMD: Use single dai for da7219 playback and capture Akshu Agrawal
2018-03-12 9:11 ` [PATCH 2/2] ASoC: AMD: Enable da7219 master clock using common clock framework Akshu Agrawal
2018-03-13 0:32 ` kbuild test robot
2018-03-13 4:37 ` kbuild test robot
2018-03-13 4:37 ` [PATCH] ASoC: AMD: fix returnvar.cocci warnings kbuild test robot
2018-03-13 11:03 ` [RFC PATCH] ASoC: AMD: da7219_dai_clk can be static kbuild test robot
2018-04-16 17:15 ` Applied "ASoC: amd: acp-da7219-max98357: Make symbol da7219_dai_clk static" to the asoc tree Mark Brown
2018-04-16 17:15 ` Mark Brown
2018-04-26 11:51 ` Mark Brown
2018-03-12 17:01 ` Mark Brown [this message]
2018-03-13 4:26 ` [PATCH 1/2] ASoC: AMD: Use single dai for da7219 playback and capture Agrawal, Akshu
2018-03-20 1:21 ` Applied "ASoC: amd: Use single dai for da7219 playback and capture" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180312170118.GL2186@sirena.org.uk \
--to=broonie@kernel.org \
--cc=akshu.agrawal@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.