From: kbuild test robot <lkp@intel.com>
To: Paolo Pisati <p.pisati@gmail.com>
Cc: kbuild-all@01.org, Alan Tull <atull@kernel.org>,
Moritz Fischer <mdf@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-fpga@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support
Date: Tue, 3 Apr 2018 01:43:03 +0800 [thread overview]
Message-ID: <201804030128.83Wu99al%fengguang.wu@intel.com> (raw)
In-Reply-To: <1522682026-11395-3-git-send-email-p.pisati@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3490 bytes --]
Hi Paolo,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.16 next-20180329]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Paolo-Pisati/fpga-Lattice-MachXO2-Slave-SPI-FPGA-Manager-support/20180403-000300
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All error/warnings (new ones prefixed by >>):
drivers/fpga/machxo2-spi.c: In function 'machxo2_spi_probe':
>> drivers/fpga/machxo2-spi.c:361:5: error: 'struct fpga_manager' has no member named 'parent'
mgr->parent = dev;
^~
>> drivers/fpga/machxo2-spi.c:367:27: error: passing argument 1 of 'fpga_mgr_register' from incompatible pointer type [-Werror=incompatible-pointer-types]
return fpga_mgr_register(mgr);
^~~
In file included from drivers/fpga/machxo2-spi.c:12:0:
include/linux/fpga/fpga-mgr.h:173:5: note: expected 'struct device *' but argument is of type 'struct fpga_manager *'
int fpga_mgr_register(struct device *dev, const char *name,
^~~~~~~~~~~~~~~~~
>> drivers/fpga/machxo2-spi.c:367:9: error: too few arguments to function 'fpga_mgr_register'
return fpga_mgr_register(mgr);
^~~~~~~~~~~~~~~~~
In file included from drivers/fpga/machxo2-spi.c:12:0:
include/linux/fpga/fpga-mgr.h:173:5: note: declared here
int fpga_mgr_register(struct device *dev, const char *name,
^~~~~~~~~~~~~~~~~
drivers/fpga/machxo2-spi.c: In function 'machxo2_spi_remove':
>> drivers/fpga/machxo2-spi.c:374:22: error: passing argument 1 of 'fpga_mgr_unregister' from incompatible pointer type [-Werror=incompatible-pointer-types]
fpga_mgr_unregister(mgr);
^~~
In file included from drivers/fpga/machxo2-spi.c:12:0:
include/linux/fpga/fpga-mgr.h:176:6: note: expected 'struct device *' but argument is of type 'struct fpga_manager *'
void fpga_mgr_unregister(struct device *dev);
^~~~~~~~~~~~~~~~~~~
drivers/fpga/machxo2-spi.c: In function 'machxo2_spi_probe':
>> drivers/fpga/machxo2-spi.c:368:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
cc1: some warnings being treated as errors
vim +361 drivers/fpga/machxo2-spi.c
346
347 static int machxo2_spi_probe(struct spi_device *spi)
348 {
349 struct device *dev = &spi->dev;
350 struct fpga_manager *mgr;
351
352 if (spi->max_speed_hz > MACHXO2_MAX_SPEED) {
353 dev_err(dev, "Speed is too high\n");
354 return -EINVAL;
355 }
356
357 mgr = devm_kzalloc(dev, sizeof(*mgr), GFP_KERNEL);
358 if (!mgr)
359 return -ENOMEM;
360
> 361 mgr->parent = dev;
362 mgr->name = "Lattice MachXO2 SPI FPGA Manager";
363 mgr->mops = &machxo2_ops;
364 mgr->priv = spi;
365 spi_set_drvdata(spi, mgr);
366
> 367 return fpga_mgr_register(mgr);
> 368 }
369
370 static int machxo2_spi_remove(struct spi_device *spi)
371 {
372 struct fpga_manager *mgr = spi_get_drvdata(spi);
373
> 374 fpga_mgr_unregister(mgr);
375
376 return 0;
377 }
378
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 63077 bytes --]
next prev parent reply other threads:[~2018-04-02 17:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 15:13 [PATCH v9 0/2] fpga: Lattice MachXO2 Slave SPI FPGA Manager support Paolo Pisati
2018-04-02 15:13 ` [PATCH v9 1/2] dt: bindings: fpga: add lattice machxo2 slave spi binding description Paolo Pisati
2018-04-02 15:13 ` [PATCH v9 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support Paolo Pisati
2018-04-02 15:39 ` Alan Tull
2018-04-02 18:35 ` Paolo Pisati
2018-04-02 17:43 ` kbuild test robot [this message]
2018-04-02 18:25 ` Alan Tull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201804030128.83Wu99al%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=atull@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@01.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mdf@kernel.org \
--cc=p.pisati@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.