From: Cornelia Huck <cohuck@redhat.com>
To: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
kvm@vger.kernel.org, borntraeger@de.ibm.com,
pasic@linux.vnet.ibm.com, pmorel@linux.vnet.ibm.com
Subject: Re: [PATCH 4/4] vfio: ccw: add traceponits for interesting error paths
Date: Tue, 10 Apr 2018 10:55:40 +0200 [thread overview]
Message-ID: <20180410105540.310ea82a.cohuck@redhat.com> (raw)
In-Reply-To: <20180410021639.GN5428@bjsdjshi@linux.vnet.ibm.com>
On Tue, 10 Apr 2018 10:16:39 +0800
Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> wrote:
> Does the following effect make sense?
>
> # tracer: nop
> #
> # _-----=> irqs-off
> # / _----=> need-resched
> # | / _---=> hardirq/softirq
> # || / _--=> preempt-depth
> # ||| / delay
> # TASK-PID CPU# |||| TIMESTAMP FUNCTION
> # | | | |||| | |
> qemu-system-s39-4252 [006] .... 231.457214: vfio_ccw_cp_prefetch: schid=0.0.013f errno=0
> qemu-system-s39-4252 [006] .... 231.457222: vfio_ccw_fsm_io_helper: schid=0.0.013f errno=0
> qemu-system-s39-4252 [006] .... 231.457223: vfio_ccw_io_fctl: schid=0.0.013f fctl=4 errno=0
> ... ...
I would likely find this useful for following a code path and making
sure the right things are called.
We certainly want error conditions traced as well (although the code
has been working too well for me to trigger that easily :)
next prev parent reply other threads:[~2018-04-10 8:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 2:08 [PATCH 0/4] vfio: ccw: error handling fixes and improvements Dong Jia Shi
2018-03-21 2:08 ` [PATCH 1/4] vfio: ccw: fix cleanup if cp_prefetch fails Dong Jia Shi
2018-03-21 12:49 ` Halil Pasic
[not found] ` <20180322022248.GB12194@bjsdjshi@linux.vnet.ibm.com>
2018-03-22 9:37 ` Pierre Morel
2018-03-22 10:10 ` Halil Pasic
2018-03-26 12:28 ` Cornelia Huck
[not found] ` <20180327014200.GH12194@bjsdjshi@linux.vnet.ibm.com>
2018-04-20 10:54 ` Halil Pasic
2018-04-20 11:36 ` Cornelia Huck
2018-04-20 11:55 ` Halil Pasic
2018-03-21 2:08 ` [PATCH 2/4] vfio: ccw: refactor and improve pfn_array_alloc_pin() Dong Jia Shi
2018-03-26 13:28 ` Cornelia Huck
[not found] ` <20180327030026.GI12194@bjsdjshi@linux.vnet.ibm.com>
2018-03-27 10:01 ` Cornelia Huck
[not found] ` <20180328023638.GL12194@bjsdjshi@linux.vnet.ibm.com>
2018-03-28 7:58 ` Cornelia Huck
2018-03-21 2:08 ` [PATCH 3/4] vfio: ccw: set ccw->cda to NULL defensively Dong Jia Shi
2018-03-26 13:47 ` Cornelia Huck
[not found] ` <20180327030809.GJ12194@bjsdjshi@linux.vnet.ibm.com>
2018-03-27 10:03 ` Cornelia Huck
2018-03-21 2:08 ` [PATCH 4/4] vfio: ccw: add traceponits for interesting error paths Dong Jia Shi
2018-03-26 13:59 ` Cornelia Huck
[not found] ` <20180327075114.GK12194@bjsdjshi@linux.vnet.ibm.com>
2018-03-27 10:07 ` Cornelia Huck
2018-03-27 15:27 ` Halil Pasic
2018-03-29 12:32 ` Cornelia Huck
[not found] ` <20180410021639.GN5428@bjsdjshi@linux.vnet.ibm.com>
2018-04-10 8:55 ` Cornelia Huck [this message]
2018-04-10 10:48 ` Halil Pasic
2018-03-26 9:02 ` [PATCH 0/4] vfio: ccw: error handling fixes and improvements Cornelia Huck
2018-03-26 11:25 ` Halil Pasic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410105540.310ea82a.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=bjsdjshi@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.vnet.ibm.com \
--cc=pmorel@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.