From: Patrick Bellasi <patrick.bellasi@arm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>, Tejun Heo <tj@kernel.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Paul Turner <pjt@google.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Juri Lelli <juri.lelli@redhat.com>,
Joel Fernandes <joelaf@google.com>,
Steve Muckle <smuckle@google.com>
Subject: Re: [PATCH 1/7] sched/core: uclamp: add CPU clamp groups accounting
Date: Fri, 13 Apr 2018 12:33:37 +0100 [thread overview]
Message-ID: <20180413113337.GU14248@e110439-lin> (raw)
In-Reply-To: <20180413112926.GQ4064@hirez.programming.kicks-ass.net>
On 13-Apr 13:29, Peter Zijlstra wrote:
> On Fri, Apr 13, 2018 at 12:17:53PM +0100, Patrick Bellasi wrote:
> > On 13-Apr 10:40, Peter Zijlstra wrote:
> > > On Mon, Apr 09, 2018 at 05:56:09PM +0100, Patrick Bellasi wrote:
> > > > +static inline void init_uclamp(void)
> > >
> > > WTH is that inline?
> >
> > You mean I can avoid the attribute?
> > ... or that I should do it in another way?
>
> yea, its init code, no need to go all inline with that (gcc will likely
> inline it anyway because static-with-single-callsite).
Yes, indeed... I think I've just got the right above init_schedstats()
as a reference and lazily want for code consistency :(
However, if we remove inline, we should probably still add an __init,
isn't it?
--
#include <best/regards.h>
Patrick Bellasi
next prev parent reply other threads:[~2018-04-13 11:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 16:56 [PATCH 0/7] Add utilization clamping support Patrick Bellasi
2018-04-09 16:56 ` [PATCH 1/7] sched/core: uclamp: add CPU clamp groups accounting Patrick Bellasi
2018-04-13 8:26 ` Peter Zijlstra
2018-04-13 10:22 ` Peter Zijlstra
2018-04-13 11:04 ` Patrick Bellasi
2018-04-13 11:15 ` Peter Zijlstra
2018-04-13 8:40 ` Peter Zijlstra
2018-04-13 11:17 ` Patrick Bellasi
2018-04-13 11:29 ` Peter Zijlstra
2018-04-13 11:33 ` Patrick Bellasi [this message]
2018-04-13 8:43 ` Peter Zijlstra
2018-04-13 11:15 ` Patrick Bellasi
2018-04-13 11:36 ` Peter Zijlstra
2018-04-13 11:47 ` Patrick Bellasi
2018-04-13 11:52 ` Patrick Bellasi
2018-04-13 12:44 ` Peter Zijlstra
2018-04-13 9:30 ` Peter Zijlstra
2018-04-13 9:38 ` Peter Zijlstra
2018-04-13 9:46 ` Peter Zijlstra
2018-04-13 11:08 ` Patrick Bellasi
2018-04-13 11:19 ` Peter Zijlstra
2018-04-09 16:56 ` [PATCH 2/7] sched/core: uclamp: map TASK clamp values into CPU clamp groups Patrick Bellasi
2018-04-09 16:56 ` [PATCH 3/7] sched/core: uclamp: extend sched_setattr to support utilization clamping Patrick Bellasi
2018-04-09 16:56 ` [PATCH 4/7] sched/core: uclamp: add utilization clamping to the CPU controller Patrick Bellasi
2018-04-09 22:24 ` Tejun Heo
2018-04-10 17:16 ` Patrick Bellasi
2018-04-10 20:05 ` Tejun Heo
2018-04-21 21:08 ` Joel Fernandes
2018-04-26 18:58 ` Tejun Heo
2018-04-09 16:56 ` [PATCH 5/7] sched/core: uclamp: use TG clamps to restrict TASK clamps Patrick Bellasi
2018-04-09 16:56 ` [PATCH 6/7] sched/cpufreq: uclamp: add utilization clamping for FAIR tasks Patrick Bellasi
2018-04-09 16:56 ` [PATCH 7/7] sched/cpufreq: uclamp: add utilization clamping for RT tasks Patrick Bellasi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180413113337.GU14248@e110439-lin \
--to=patrick.bellasi@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=joelaf@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rafael.j.wysocki@intel.com \
--cc=smuckle@google.com \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.