From: Patchwork <patchwork@emeril.freedesktop.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm: Drop DRM_CONTROL_ALLOW from ioctls
Date: Fri, 20 Apr 2018 07:29:58 -0000 [thread overview]
Message-ID: <20180420072958.20365.59513@emeril.freedesktop.org> (raw)
In-Reply-To: <20180420065159.4531-1-daniel.vetter@ffwll.ch>
== Series Details ==
Series: series starting with [1/4] drm: Drop DRM_CONTROL_ALLOW from ioctls
URL : https://patchwork.freedesktop.org/series/42012/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
6f5ce675325d drm: Drop DRM_CONTROL_ALLOW from ioctls
-:8: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes")'
#8:
commit 8a357d10043c75e980e7fcdb60d2b913491564af
-:16: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6449b088dd51 ("drm: Add fake controlD* symlinks for backwards compat")'
#16:
commit 6449b088dd51dd5aa6b38455888bbf538d21f2fc
-:43: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#43: FILE: drivers/gpu/drm/drm_ioc32.c:108:
+ DRM_UNLOCKED|DRM_RENDER_ALLOW);
^
-:65: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#65: FILE: drivers/gpu/drm/drm_ioctl.c:542:
+ DRM_UNLOCKED|DRM_RENDER_ALLOW),
^
-:87: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#87: FILE: drivers/gpu/drm/drm_ioctl.c:623:
+ DRM_IOCTL_DEF(DRM_IOCTL_MODE_SETCRTC, drm_mode_setcrtc, DRM_MASTER|DRM_UNLOCKED),
^
-:89: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#89: FILE: drivers/gpu/drm/drm_ioctl.c:625:
+ DRM_IOCTL_DEF(DRM_IOCTL_MODE_SETPLANE, drm_mode_setplane, DRM_MASTER|DRM_UNLOCKED),
^
-:90: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#90: FILE: drivers/gpu/drm/drm_ioctl.c:626:
+ DRM_IOCTL_DEF(DRM_IOCTL_MODE_CURSOR, drm_mode_cursor_ioctl, DRM_MASTER|DRM_UNLOCKED),
^
-:117: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#117: FILE: drivers/gpu/drm/drm_ioctl.c:631:
+ DRM_IOCTL_DEF(DRM_IOCTL_MODE_ATTACHMODE, drm_noop, DRM_MASTER|DRM_UNLOCKED),
^
-:118: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#118: FILE: drivers/gpu/drm/drm_ioctl.c:632:
+ DRM_IOCTL_DEF(DRM_IOCTL_MODE_DETACHMODE, drm_noop, DRM_MASTER|DRM_UNLOCKED),
^
-:120: WARNING:LONG_LINE: line over 100 characters
#120: FILE: drivers/gpu/drm/drm_ioctl.c:634:
+ DRM_IOCTL_DEF(DRM_IOCTL_MODE_SETPROPERTY, drm_mode_connector_property_set_ioctl, DRM_MASTER|DRM_UNLOCKED),
-:120: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#120: FILE: drivers/gpu/drm/drm_ioctl.c:634:
+ DRM_IOCTL_DEF(DRM_IOCTL_MODE_SETPROPERTY, drm_mode_connector_property_set_ioctl, DRM_MASTER|DRM_UNLOCKED),
^
-:126: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#126: FILE: drivers/gpu/drm/drm_ioctl.c:640:
+ DRM_IOCTL_DEF(DRM_IOCTL_MODE_PAGE_FLIP, drm_mode_page_flip_ioctl, DRM_MASTER|DRM_UNLOCKED),
^
-:127: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#127: FILE: drivers/gpu/drm/drm_ioctl.c:641:
+ DRM_IOCTL_DEF(DRM_IOCTL_MODE_DIRTYFB, drm_mode_dirtyfb_ioctl, DRM_MASTER|DRM_UNLOCKED),
^
-:131: WARNING:LONG_LINE: line over 100 characters
#131: FILE: drivers/gpu/drm/drm_ioctl.c:645:
+ DRM_IOCTL_DEF(DRM_IOCTL_MODE_OBJ_GETPROPERTIES, drm_mode_obj_get_properties_ioctl, DRM_UNLOCKED),
-:132: WARNING:LONG_LINE: line over 100 characters
#132: FILE: drivers/gpu/drm/drm_ioctl.c:646:
+ DRM_IOCTL_DEF(DRM_IOCTL_MODE_OBJ_SETPROPERTY, drm_mode_obj_set_property_ioctl, DRM_MASTER|DRM_UNLOCKED),
-:132: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#132: FILE: drivers/gpu/drm/drm_ioctl.c:646:
+ DRM_IOCTL_DEF(DRM_IOCTL_MODE_OBJ_SETPROPERTY, drm_mode_obj_set_property_ioctl, DRM_MASTER|DRM_UNLOCKED),
^
-:133: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#133: FILE: drivers/gpu/drm/drm_ioctl.c:647:
+ DRM_IOCTL_DEF(DRM_IOCTL_MODE_CURSOR2, drm_mode_cursor2_ioctl, DRM_MASTER|DRM_UNLOCKED),
^
-:134: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#134: FILE: drivers/gpu/drm/drm_ioctl.c:648:
+ DRM_IOCTL_DEF(DRM_IOCTL_MODE_ATOMIC, drm_mode_atomic_ioctl, DRM_MASTER|DRM_UNLOCKED),
^
-:148: WARNING:LONG_LINE: line over 100 characters
#148: FILE: drivers/gpu/drm/drm_ioctl.c:668:
+ DRM_IOCTL_DEF(DRM_IOCTL_MODE_CREATE_LEASE, drm_mode_create_lease_ioctl, DRM_MASTER|DRM_UNLOCKED),
-:148: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#148: FILE: drivers/gpu/drm/drm_ioctl.c:668:
+ DRM_IOCTL_DEF(DRM_IOCTL_MODE_CREATE_LEASE, drm_mode_create_lease_ioctl, DRM_MASTER|DRM_UNLOCKED),
^
-:149: WARNING:LONG_LINE: line over 100 characters
#149: FILE: drivers/gpu/drm/drm_ioctl.c:669:
+ DRM_IOCTL_DEF(DRM_IOCTL_MODE_LIST_LESSEES, drm_mode_list_lessees_ioctl, DRM_MASTER|DRM_UNLOCKED),
-:149: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#149: FILE: drivers/gpu/drm/drm_ioctl.c:669:
+ DRM_IOCTL_DEF(DRM_IOCTL_MODE_LIST_LESSEES, drm_mode_list_lessees_ioctl, DRM_MASTER|DRM_UNLOCKED),
^
-:150: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#150: FILE: drivers/gpu/drm/drm_ioctl.c:670:
+ DRM_IOCTL_DEF(DRM_IOCTL_MODE_GET_LEASE, drm_mode_get_lease_ioctl, DRM_MASTER|DRM_UNLOCKED),
^
-:151: WARNING:LONG_LINE: line over 100 characters
#151: FILE: drivers/gpu/drm/drm_ioctl.c:671:
+ DRM_IOCTL_DEF(DRM_IOCTL_MODE_REVOKE_LEASE, drm_mode_revoke_lease_ioctl, DRM_MASTER|DRM_UNLOCKED),
-:151: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#151: FILE: drivers/gpu/drm/drm_ioctl.c:671:
+ DRM_IOCTL_DEF(DRM_IOCTL_MODE_REVOKE_LEASE, drm_mode_revoke_lease_ioctl, DRM_MASTER|DRM_UNLOCKED),
^
total: 2 errors, 6 warnings, 17 checks, 108 lines checked
29e6369e9d4c drm/i915: Drop DRM_CONTROL_ALLOW
7b3d25c0fdce drm/vmwgfx: Drop DRM_CONTROL_ALLOW
0708a46fb821 drm: remove all control node code
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-04-20 7:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 6:51 [PATCH 1/4] drm: Drop DRM_CONTROL_ALLOW from ioctls Daniel Vetter
2018-04-20 6:51 ` [PATCH 2/4] drm/i915: Drop DRM_CONTROL_ALLOW Daniel Vetter
2018-04-23 8:26 ` Joonas Lahtinen
2018-05-02 15:02 ` Sean Paul
2018-04-20 6:51 ` [PATCH 3/4] drm/vmwgfx: " Daniel Vetter
2018-04-20 17:56 ` Thomas Hellstrom
2018-04-24 13:01 ` Daniel Vetter
2018-04-24 13:25 ` Thomas Hellstrom
2018-05-02 15:03 ` Sean Paul
2018-04-20 6:51 ` [PATCH 4/4] drm: remove all control node code Daniel Vetter
2018-05-02 20:10 ` Sean Paul
2018-05-03 9:28 ` Daniel Vetter
2018-05-03 9:32 ` Daniel Vetter
2018-04-20 7:29 ` Patchwork [this message]
2018-04-20 7:44 ` ✓ Fi.CI.BAT: success for series starting with [1/4] drm: Drop DRM_CONTROL_ALLOW from ioctls Patchwork
2018-04-20 8:32 ` ✓ Fi.CI.IGT: " Patchwork
2018-04-25 9:07 ` [PATCH] drm/msm: Don't setup control node debugfs files Daniel Vetter
2018-05-02 15:03 ` Sean Paul
2018-05-03 9:31 ` Daniel Vetter
2018-05-03 15:16 ` Sean Paul
2018-05-03 19:29 ` Daniel Vetter
2018-05-02 15:02 ` [PATCH 1/4] drm: Drop DRM_CONTROL_ALLOW from ioctls Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420072958.20365.59513@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.