From: "Du, Changbin" <changbin.du@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: changbin.du@intel.com, yamada.masahiro@socionext.com,
michal.lkml@markovi.net, tglx@linutronix.de, mingo@redhat.com,
akpm@linux-foundation.org, rostedt@goodmis.org,
rdunlap@infradead.org, x86@kernel.org, lgirdwood@gmail.com,
arnd@arndb.de, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH v3 2/5] regulator: add dummy function of_find_regulator_by_node
Date: Wed, 9 May 2018 16:13:42 +0800 [thread overview]
Message-ID: <20180509081341.ahx7xuqs366gmqaf@intel.com> (raw)
In-Reply-To: <20180509082114.GQ13402@sirena.org.uk>
On Wed, May 09, 2018 at 05:21:14PM +0900, Mark Brown wrote:
> On Sun, May 06, 2018 at 08:20:13AM +0800, changbin.du@intel.com wrote:
> > From: Changbin Du <changbin.du@intel.com>
> >
> > If device tree is not enabled, of_find_regulator_by_node() should have
> > a dummy function since the function call is still there.
>
> Please do not submit new versions of already applied patches, please
> submit incremental updates to the existing code. Modifying existing
> commits creates problems for other users building on top of those
> commits so it's best practice to only change pubished git commits if
> absolutely essential.
Hmm, I saw your merging notification too late. Let me refresh the series. Sorry
for confusing.
--
Thanks,
Changbin Du
next prev parent reply other threads:[~2018-05-09 8:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-06 0:20 [PATCH v3 0/5] kernel hacking: GCC optimization for better debug experience (-Og) changbin.du
2018-05-06 0:20 ` [PATCH v3 1/5] x86/mm: surround level4_kernel_pgt with #ifdef CONFIG_X86_5LEVEL...#endif changbin.du
2018-05-06 0:20 ` [PATCH v3 2/5] regulator: add dummy function of_find_regulator_by_node changbin.du
2018-05-09 8:21 ` Mark Brown
2018-05-09 8:13 ` Du, Changbin [this message]
2018-05-09 8:39 ` Mark Brown
2018-05-06 0:20 ` [PATCH v3 3/5] kernel hacking: new config NO_AUTO_INLINE to disable compiler auto-inline optimizations changbin.du
2018-05-06 5:50 ` kbuild test robot
2018-05-06 5:50 ` kbuild test robot
2018-05-06 5:50 ` kbuild test robot
2018-05-06 6:15 ` kbuild test robot
2018-05-06 6:15 ` kbuild test robot
2018-05-06 0:20 ` [PATCH v3 4/5] kernel hacking: new config CC_OPTIMIZE_FOR_DEBUGGING to apply GCC -Og optimization changbin.du
2018-05-06 0:20 ` [PATCH v3 5/5] asm-generic: fix build error in fix_to_virt with CONFIG_CC_OPTIMIZE_FOR_DEBUGGING changbin.du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180509081341.ahx7xuqs366gmqaf@intel.com \
--to=changbin.du@intel.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=mingo@redhat.com \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.