From: Al Viro <viro@ZenIV.linux.org.uk>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Jeff Layton <jlayton@kernel.org>
Subject: Re: [RFC][PATCH] nfsd: vfs_mkdir() might succeed leaving dentry negative unhashed
Date: Mon, 14 May 2018 18:00:41 +0100 [thread overview]
Message-ID: <20180514170041.GJ30522@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20180514162704.GE7160@fieldses.org>
On Mon, May 14, 2018 at 12:27:04PM -0400, J. Bruce Fields wrote:
> > > if (!err)
> > > err = fh_update(reshp);
> > >
> > > at the end of nfsd_create_locked.
> >
> > Might be too late for that, though - the trouble hits when we hit
> > nfsd_create_setattr().
>
> Oh, got it. Could move the bottom fh_update to just above the
> nfsd_create_setattr(), though?
Probably, but I'm not comfortable enough with the nfsd guts wrt in-core
fhandle and assumptions made by users of such, so I'd rather bounce that
question to nfsd maintainers ;-)
next prev parent reply other threads:[~2018-05-14 17:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 21:13 [RFC][PATCH] nfsd: vfs_mkdir() might succeed leaving dentry negative unhashed Al Viro
2018-05-14 15:32 ` J. Bruce Fields
2018-05-14 15:45 ` Al Viro
2018-05-14 16:27 ` J. Bruce Fields
2018-05-14 17:00 ` Al Viro [this message]
2018-05-14 17:56 ` J. Bruce Fields
2018-05-14 16:47 ` Al Viro
2018-05-16 14:09 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514170041.GJ30522@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=bfields@fieldses.org \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.