From: Christoph Hellwig <hch@lst.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: akpm@linux-foundation.org, stable@vger.kernel.org,
"Christoph Hellwig" <hch@lst.de>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Logan Gunthorpe" <logang@deltatee.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] mm, devm_memremap_pages: handle errors allocating final devres action
Date: Tue, 22 May 2018 08:30:06 +0200 [thread overview]
Message-ID: <20180522063006.GB7925@lst.de> (raw)
In-Reply-To: <152694212460.5484.13180030631810166467.stgit@dwillia2-desk3.amr.corp.intel.com>
On Mon, May 21, 2018 at 03:35:24PM -0700, Dan Williams wrote:
> The last step before devm_memremap_pages() returns success is to
> allocate a release action to tear the entire setup down. However, the
> result from devm_add_action() is not checked.
>
> Checking the error also means that we need to handle the fact that the
> percpu_ref may not be killed by the time devm_memremap_pages_release()
> runs. Add a new state flag for this case.
Looks good (modulo any stable tag issues):
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2018-05-22 6:30 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 22:35 [PATCH 0/5] mm: rework hmm to use devm_memremap_pages Dan Williams
2018-05-21 22:35 ` [PATCH 1/5] mm, devm_memremap_pages: mark devm_memremap_pages() EXPORT_SYMBOL_GPL Dan Williams
2018-05-21 22:35 ` Dan Williams
2018-05-22 6:29 ` Christoph Hellwig
2018-05-21 22:35 ` [PATCH 2/5] mm, devm_memremap_pages: handle errors allocating final devres action Dan Williams
2018-05-21 22:35 ` Dan Williams
2018-05-21 23:10 ` Andrew Morton
2018-05-22 0:07 ` Dan Williams
2018-05-22 16:42 ` Logan Gunthorpe
2018-05-22 16:56 ` Dan Williams
2018-05-22 17:03 ` Logan Gunthorpe
2018-05-22 17:25 ` Dan Williams
2018-05-22 17:36 ` Logan Gunthorpe
2018-05-22 6:30 ` Christoph Hellwig [this message]
2018-05-21 22:35 ` [PATCH 3/5] mm, hmm: use devm semantics for hmm_devmem_{add, remove} Dan Williams
2018-05-21 22:35 ` Dan Williams
2018-05-22 6:30 ` Christoph Hellwig
2018-05-21 22:35 ` [PATCH 4/5] mm, hmm: replace hmm_devmem_pages_create() with devm_memremap_pages() Dan Williams
2018-05-21 22:35 ` Dan Williams
2018-05-22 6:31 ` Christoph Hellwig
2018-05-22 17:13 ` Logan Gunthorpe
2018-05-22 21:38 ` Dan Williams
2018-05-21 22:35 ` [PATCH 5/5] mm, hmm: mark hmm_devmem_{add, add_resource} EXPORT_SYMBOL_GPL Dan Williams
2018-05-21 22:35 ` Dan Williams
2018-05-22 6:32 ` Christoph Hellwig
2018-05-22 21:31 ` Andrew Morton
2018-06-05 18:24 ` Jerome Glisse
2018-06-05 18:24 ` Jerome Glisse
2018-05-24 0:10 ` [PATCH 0/5] mm: rework hmm to use devm_memremap_pages Jerome Glisse
2018-05-24 3:18 ` Dan Williams
2018-05-24 6:35 ` Christoph Hellwig
2018-05-29 22:22 ` Dave Airlie
2018-05-29 22:31 ` Dan Williams
2018-05-29 23:00 ` Dave Airlie
2018-05-29 23:33 ` Dan Williams
2018-06-05 18:48 ` Jerome Glisse
2018-06-05 18:48 ` Jerome Glisse
2018-06-05 22:19 ` Dave Airlie
2018-06-05 23:06 ` Dan Williams
2018-06-06 0:08 ` Jerome Glisse
2018-06-06 0:08 ` Jerome Glisse
2018-06-06 1:33 ` Dan Williams
2018-06-06 7:14 ` Christoph Hellwig
2018-06-07 14:16 ` Jerome Glisse
2018-06-07 14:16 ` Jerome Glisse
2018-06-07 18:39 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180522063006.GB7925@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.