From: Vinod <vkoul@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
Sricharan R <sricharan@codeaurora.org>,
Sibi Sankar <sibis@codeaurora.org>,
Rohit kumar <rohitkr@codeaurora.org>,
Andy Gross <andy.gross@linaro.org>,
linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [RFC PATCH 5/5] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver
Date: Wed, 23 May 2018 11:35:16 +0530 [thread overview]
Message-ID: <20180523060516.GD20991@vkoul-mobl> (raw)
In-Reply-To: <20180523052054.19025-6-bjorn.andersson@linaro.org>
On 22-05-18, 22:20, Bjorn Andersson wrote:
> +static int q6v5_wcss_reset(struct q6v5_wcss *wcss)
> +{
> + int ret;
> + u32 val;
> + int i;
> +
> + /* Assert resets, stop core */
> + val = readl(wcss->reg_base + QDSP6SS_RESET_REG);
> + val |= Q6SS_CORE_ARES | Q6SS_BUS_ARES_ENABLE | Q6SS_STOP_CORE;
> + writel(val, wcss->reg_base + QDSP6SS_RESET_REG);
> +
> + /* BHS require xo cbcr to be enabled */
> + val = readl(wcss->reg_base + QDSP6SS_XO_CBCR);
> + val |= 0x1;
> + writel(val, wcss->reg_base + QDSP6SS_XO_CBCR);
As commented on previous patch, it would help IMO to add a modify() wrapper
here which would perform read, modify and write.
Looking at the patch, few other comments would be applicable too, so would be
great if you/Sricharan can update this
--
~Vinod
next prev parent reply other threads:[~2018-05-23 6:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 5:20 [RFC PATCH 0/5] Hexagon remoteproc spring cleaning Bjorn Andersson
2018-05-23 5:20 ` [RFC PATCH 1/5] remoteproc: qcom: mdt_loader: Make the firmware authentication optional Bjorn Andersson
2018-05-23 5:20 ` [RFC PATCH 2/5] remoteproc: q6v5: Extract common resource handling Bjorn Andersson
2018-06-01 6:16 ` Sricharan R
2018-06-01 15:18 ` Sibi S
2018-06-01 16:39 ` Sricharan R
2018-05-23 5:20 ` [RFC PATCH 3/5] remoteproc: qcom: adsp: Use common q6v5 helpers Bjorn Andersson
2018-06-01 6:25 ` Sricharan R
2018-06-01 13:35 ` Rohit Kumar
2018-05-23 5:20 ` [RFC PATCH 4/5] remoteproc: qcom: q6v5-pil: " Bjorn Andersson
2018-06-01 6:42 ` Sricharan R
2018-05-23 5:20 ` [RFC PATCH 5/5] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver Bjorn Andersson
2018-05-23 6:05 ` Vinod [this message]
2018-05-23 6:58 ` Bjorn Andersson
2018-05-23 7:37 ` Vinod
2018-05-23 14:48 ` Sricharan R
2018-05-29 4:07 ` Bjorn Andersson
2018-05-29 8:32 ` Sricharan R
2018-06-01 13:33 ` [RFC PATCH 0/5] Hexagon remoteproc spring cleaning Rohit Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180523060516.GD20991@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=rohitkr@codeaurora.org \
--cc=sibis@codeaurora.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.