From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>, Keith Busch <keith.busch@intel.com>
Cc: Bart Van Assche <bart.vanassche@wdc.com>,
Ming Lei <ming.lei@redhat.com>,
Josef Bacik <josef@toxicpanda.com>, Tejun Heo <tj@kernel.org>,
Lee Duncan <lduncan@suse.com>, Chris Leech <cleech@redhat.com>,
Rafael David Tinoco <rafael.tinoco@canonical.com>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: BLK_EH_HANDLED
Date: Wed, 23 May 2018 14:19:27 +0200 [thread overview]
Message-ID: <20180523121941.8632-1-hch@lst.de> (raw)
Hi all,
this series removes the BLK_EH_HANDLED return value, and instead places
responsibility of timed out commands entirely on the drivers. Except
for some odd layering vilations in libiscsi this actually is
surprisingly simple. The last two pathes contain a respin of Keith'
series to refcount struct request in the eye of timeouts. Once the
BLK_EH_HANDLED special case is gone this actually seems the EH fixing
approach that seems the most sensible to me.
next reply other threads:[~2018-05-23 12:19 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 12:19 Christoph Hellwig [this message]
2018-05-23 12:19 ` [PATCH 01/14] libata: remove ata_scsi_timed_out Christoph Hellwig
2018-05-23 13:21 ` Hannes Reinecke
2018-05-23 12:19 ` [PATCH 02/14] block: rename BLK_EH_NOT_HANDLED to BLK_EH_DONE Christoph Hellwig
2018-05-23 12:41 ` Johannes Thumshirn
2018-05-23 13:22 ` Hannes Reinecke
2018-05-23 12:19 ` [PATCH 03/14] nvme: return BLK_EH_DONE from ->timeout Christoph Hellwig
2018-05-23 12:42 ` Johannes Thumshirn
2018-05-23 13:27 ` Hannes Reinecke
2018-05-28 15:24 ` Christoph Hellwig
2018-05-24 4:45 ` Ming Lei
2018-05-28 11:44 ` Christoph Hellwig
2018-05-29 0:50 ` Ming Lei
2018-05-23 12:19 ` [PATCH 04/14] nbd: complete requests " Christoph Hellwig
2018-05-23 13:28 ` Hannes Reinecke
2018-05-28 15:25 ` Christoph Hellwig
2018-05-23 12:19 ` [PATCH 05/14] mtip32xx: " Christoph Hellwig
2018-05-23 12:46 ` Johannes Thumshirn
2018-05-23 13:29 ` Hannes Reinecke
2018-05-23 12:19 ` [PATCH 06/14] null_blk: " Christoph Hellwig
2018-05-23 12:46 ` Johannes Thumshirn
2018-05-23 13:29 ` Hannes Reinecke
2018-05-23 12:19 ` [PATCH 07/14] scsi_transport_fc: " Christoph Hellwig
2018-05-23 12:48 ` Johannes Thumshirn
2018-05-23 13:30 ` Hannes Reinecke
2018-05-23 12:19 ` [PATCH 08/14] mmc: " Christoph Hellwig
2018-05-23 13:31 ` Hannes Reinecke
2018-05-23 12:19 ` [PATCH 09/14] libiscsi: don't try to bypass SCSI EH Christoph Hellwig
2018-05-23 13:35 ` Hannes Reinecke
2018-05-23 12:19 ` [PATCH 10/14] block: remove BLK_EH_HANDLED Christoph Hellwig
2018-05-23 13:36 ` Hannes Reinecke
2018-05-23 12:19 ` [PATCH 11/14] block: document the blk_eh_timer_return values Christoph Hellwig
2018-05-23 13:36 ` Hannes Reinecke
2018-05-23 12:19 ` [PATCH 12/14] blk-mq: Fix timeout and state order Christoph Hellwig
2018-05-23 13:37 ` Hannes Reinecke
2018-05-23 12:19 ` [PATCH 13/14] blk-mq: Remove generation seqeunce Christoph Hellwig
2018-05-23 14:24 ` Keith Busch
2018-05-23 12:19 ` [PATCH 14/14] blk-mq: simplify blk_mq_rq_timed_out Christoph Hellwig
2018-05-23 13:20 ` BLK_EH_HANDLED Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180523121941.8632-1-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=cleech@redhat.com \
--cc=josef@toxicpanda.com \
--cc=keith.busch@intel.com \
--cc=lduncan@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=rafael.tinoco@canonical.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.