All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 17/17] RFT drm/i915/gtt: Enable full-ppgtt by default everywhere
Date: Wed,  6 Jun 2018 07:27:10 +0100	[thread overview]
Message-ID: <20180606062710.29984-18-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20180606062710.29984-1-chris@chris-wilson.co.uk>

Let's see if we have all the kinks worked out and full-ppgtt now works
reliably on gen7 (Ivybridge, Valleyview/Baytrail and Haswell). If we can
let userspace have full control over their own ppgtt, it makes softpinning
far more effective, in turn making GPU dispatch far more efficient and
more secure (due to better mm segregation).

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 81e846664fdf..314b7b29a5a3 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -179,13 +179,11 @@ int intel_sanitize_enable_ppgtt(struct drm_i915_private *dev_priv,
 		return 0;
 	}
 
-	if (HAS_LOGICAL_RING_CONTEXTS(dev_priv)) {
-		if (has_full_48bit_ppgtt)
-			return 3;
+	if (has_full_48bit_ppgtt)
+		return 3;
 
-		if (has_full_ppgtt)
-			return 2;
-	}
+	if (has_full_ppgtt)
+		return 2;
 
 	return 1;
 }
-- 
2.17.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-06-06  6:28 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-06  6:26 Full ppgtt for hsw, closer Chris Wilson
2018-06-06  6:26 ` [PATCH 01/17] drm/i915/gtt: Invalidate GGTT caches after writing the gen6 page directories Chris Wilson
2018-06-06  6:26 ` [PATCH 02/17] drm/i915: Prepare for non-object vma Chris Wilson
2018-06-06 23:18   ` Matthew Auld
2018-06-06  6:26 ` [PATCH 03/17] drm/i915: Decouple vma vfuncs from vm Chris Wilson
2018-06-06  6:26 ` [PATCH 04/17] drm/i915/gtt: Push allocation to hw ppgtt constructor Chris Wilson
2018-06-06  6:26 ` [PATCH 05/17] drm/i915/gtt: Subclass gen6_hw_ppgtt Chris Wilson
2018-06-06  6:26 ` [PATCH 06/17] drm/i915/gtt Onionify error handling for gen6_ppgtt_create Chris Wilson
2018-06-06 23:24   ` Matthew Auld
2018-06-06 23:25     ` Matthew Auld
2018-06-06  6:27 ` [PATCH 07/17] drm/i915/gtt: Reorder aliasing_ppgtt fini Chris Wilson
2018-06-06 23:29   ` Matthew Auld
2018-06-06  6:27 ` [PATCH 08/17] drm/i915/gtt: Make gen6 page directories evictable Chris Wilson
2018-06-06  6:45   ` [PATCH] " Chris Wilson
2018-06-06  6:51   ` Chris Wilson
2018-06-06 23:07     ` Matthew Auld
2018-06-06  6:27 ` [PATCH 09/17] drm/i915/gtt: Only keep gen6 page directories pinned while active Chris Wilson
2018-06-06  6:27 ` [PATCH 10/17] drm/i915/gtt: Lazily allocate page directories for gen7 Chris Wilson
2018-06-06 22:25   ` Matthew Auld
2018-06-06  6:27 ` [PATCH 11/17] drm/i915/gtt: Free unused page tables on unbind the context Chris Wilson
2018-06-06 22:27   ` Matthew Auld
2018-06-06  6:27 ` [PATCH 12/17] drm/i915/gtt: Skip initializing PT with scratch if full Chris Wilson
2018-06-06 22:27   ` Matthew Auld
2018-06-06  6:27 ` [PATCH 13/17] drm/i915/gtt: Cache the PTE encoding of the scratch page Chris Wilson
2018-06-06 22:29   ` Matthew Auld
2018-06-06  6:27 ` [PATCH 14/17] drm/i915/gtt: Reduce a pair of runtime asserts Chris Wilson
2018-06-06 22:32   ` Matthew Auld
2018-06-06  6:27 ` [PATCH 15/17] drm/i915/gtt: Skip clearing the GGTT under gen6+ full-ppgtt Chris Wilson
2018-06-06  6:27 ` [PATCH 16/17] drm/i915/ringbuffer: Force restore of mm after failed context switch Chris Wilson
2018-06-06  6:27 ` Chris Wilson [this message]
2018-06-06  6:43 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/17] drm/i915/gtt: Invalidate GGTT caches after writing the gen6 page directories Patchwork
2018-06-06  6:47 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-06-06  7:03 ` ✓ Fi.CI.BAT: success " Patchwork
2018-06-06  7:07 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/17] drm/i915/gtt: Invalidate GGTT caches after writing the gen6 page directories (rev3) Patchwork
2018-06-06  7:12 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-06-06  7:23 ` ✓ Fi.CI.BAT: success " Patchwork
2018-06-06  9:42 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180606062710.29984-18-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.