From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/7] mkfs: parameterize sysconfdir in mkfs.xfs.8
Date: Tue, 12 Jun 2018 15:09:12 -0700 [thread overview]
Message-ID: <20180612220912.GN22045@magnolia> (raw)
In-Reply-To: <1528831883-21879-4-git-send-email-sandeen@sandeen.net>
On Tue, Jun 12, 2018 at 02:31:19PM -0500, Eric Sandeen wrote:
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> man/man8/mkfs.xfs.8.in | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/man/man8/mkfs.xfs.8.in b/man/man8/mkfs.xfs.8.in
> index dcd95ad..8ea2fe9 100644
> --- a/man/man8/mkfs.xfs.8.in
> +++ b/man/man8/mkfs.xfs.8.in
> @@ -131,7 +131,7 @@ contains built-in default values for every option as described in the sections
> below.
> These built-in defaults may evolve over time as new capabilities are added.
> If the file
> -.B /etc/xfs/mkfs/defaults
> +.B @sysconfdir@/xfs/mkfs/defaults
> exists, it will be parsed to override built-in defaults, and the defaults
> described in sections below may no longer apply.
> .PP
> @@ -143,7 +143,7 @@ as described in the OPTIONS section.
> .TP
> .BI \-c " configuration"
> This option may be used to specify a configuration file other than
> -.B /etc/xfs/mkfs/defaults
> +.B @sysconfdir@/xfs/mkfs/defaults
> to override selected built-in parameter defaults.
> If
> .B configuration
> @@ -155,7 +155,7 @@ Otherwise,
> will search for
> .B configuration
> first in the current working directory, and then in the
> -.B /etc/xfs/mkfs/
> +.B @sysconfdir@/xfs/mkfs/
> directory.
> See also the CONFIGURATION FILE FORMAT section below.
> .TP
> @@ -958,7 +958,7 @@ Do not attempt to discard blocks at mkfs time.
> Prints the version number and exits.
> .SH CONFIGURATION FILE FORMAT
> The optional default configuration file in
> -.B /etc/xfs/mkfs/default
> +.B @sysconfdir@/xfs/mkfs/default
> as well as any alternate configuration file specified via the
> .B \-c
> option follow a simple ini-style format as shown below.
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-06-12 22:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 19:31 [PATCH 0/7] mkfs config support cleanups Eric Sandeen
2018-06-12 19:31 ` [PATCH 1/7] mkfs: document the config file option Eric Sandeen
2018-06-12 22:13 ` Darrick J. Wong
2018-06-12 19:31 ` [PATCH 2/7] mkfs: move mkfs.xfs.8 to an .in file Eric Sandeen
2018-06-12 19:45 ` Eric Sandeen
2018-06-12 22:10 ` Darrick J. Wong
2018-06-12 23:15 ` Eric Sandeen
2018-06-12 19:31 ` [PATCH 3/7] mkfs: parameterize sysconfdir in mkfs.xfs.8 Eric Sandeen
2018-06-12 22:09 ` Darrick J. Wong [this message]
2018-06-12 19:31 ` [PATCH 4/7] mkfs: tidy up whitespace in mkfs/config.c Eric Sandeen
2018-06-12 22:09 ` Darrick J. Wong
2018-06-12 19:31 ` [PATCH 5/7] mkfs: properly fix TOCTOU open/stat race in config file handling Eric Sandeen
2018-06-12 22:14 ` Darrick J. Wong
2018-06-12 19:31 ` [PATCH 6/7] mkfs: consolidate and streamline config opening function Eric Sandeen
2018-06-12 22:21 ` Darrick J. Wong
2018-06-13 0:01 ` Darrick J. Wong
2018-06-12 19:31 ` [PATCH 7/7] mkfs: remove gotos in parse_defaults_file Eric Sandeen
2018-06-12 22:23 ` Darrick J. Wong
2018-06-12 22:27 ` [PATCH 0/7] mkfs config support cleanups Darrick J. Wong
2018-06-12 23:17 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180612220912.GN22045@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.