✗ Fi.CI.CHECKPATCH: warning for Improve crc-core driver interface

From: Patchwork <patchwork@emeril.freedesktop.org>
To: Mahesh Kumar <mahesh1.kumar@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for Improve crc-core driver interface
Date: Fri, 22 Jun 2018 10:46:52 -0000	[thread overview]
Message-ID: <20180622104652.30805.82815@emeril.freedesktop.org> (raw)
In-Reply-To: <20180622104134.6823-1-mahesh1.kumar@intel.com>

== Series Details ==

Series: Improve crc-core driver interface
URL   : https://patchwork.freedesktop.org/series/45246/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
029f1bb122df drm: crc: Introduce verify_crc_source callback
5ec7aa87b40a drm: crc: Introduce pre_crc_read function
480f7d04332c drm: crc: Introduce get_crc_sources callback
d4423129d7d1 drm/rockchip/crc: Implement verify_crc_source callback
-:21: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#21: FILE: drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1143:
+static int vop_crtc_verify_crc_source(struct drm_crtc *crtc,
+				   const char *source_name, size_t *values_cnt)

-:39: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#39: FILE: drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1161:
+static int vop_crtc_verify_crc_source(struct drm_crtc *crtc,
+				   const char *source_name, size_t *values_cnt)

total: 0 errors, 0 warnings, 2 checks, 37 lines checked
610d591b94d6 drm/amdgpu_dm/crc: Implement verify_crc_source callback
891094e98e2a drm/rcar-du/crc: Implement verify_crc_source callback
-:19: CHECK:LINE_SPACING: Please don't use multiple blank lines
#19: FILE: drivers/gpu/drm/rcar-du/rcar_du_crtc.c:759:
 
+

-:37: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#37: FILE: drivers/gpu/drm/rcar-du/rcar_du_crtc.c:777:
+	} else if (strstarts(source_name, "plane")) {
+

total: 0 errors, 0 warnings, 2 checks, 54 lines checked
8bba28049862 drm/i915/crc: implement verify_crc_source callback
-:137: CHECK:LINE_SPACING: Please don't use multiple blank lines
#137: FILE: drivers/gpu/drm/i915/intel_pipe_crc.c:1004:
+
+

-:150: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#150: FILE: drivers/gpu/drm/i915/intel_pipe_crc.c:1017:
+	if (source == INTEL_PIPE_CRC_SOURCE_AUTO ||
+			intel_is_valid_crc_source(dev_priv, source) == 0) {

total: 0 errors, 0 warnings, 2 checks, 135 lines checked
042fb1777a2a drm/i915/crc: implement get_crc_sources callback
4820bcc2bfff drm/crc: Cleanup crtc_crc_open function
3493f69dc14c Revert "drm: crc: Wait for a frame before returning from open()"

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx