From: Boris Brezillon <boris.brezillon@bootlin.com>
To: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org
Cc: Liviu Dudau <Liviu.Dudau@arm.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Boris Brezillon <boris.brezillon@bootlin.com>
Subject: [PATCH v4 2/8] drm/connector: Pass a drm_connector_state to ->atomic_commit()
Date: Tue, 3 Jul 2018 09:50:16 +0200 [thread overview]
Message-ID: <20180703075022.15138-3-boris.brezillon@bootlin.com> (raw)
In-Reply-To: <20180703075022.15138-1-boris.brezillon@bootlin.com>
Other atomic hooks are passed state objects, let's change this one to
be consistent.
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
Changes in v4:
- None
Changes in v3:
- Add Liviu's A-b and Daniel's R-b
Changes in v2:
- New patch
---
drivers/gpu/drm/drm_atomic_helper.c | 2 +-
include/drm/drm_modeset_helper_vtables.h | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
index 17baf5057132..69063bcf2334 100644
--- a/drivers/gpu/drm/drm_atomic_helper.c
+++ b/drivers/gpu/drm/drm_atomic_helper.c
@@ -1187,7 +1187,7 @@ static void drm_atomic_helper_commit_writebacks(struct drm_device *dev,
if (new_conn_state->writeback_job && new_conn_state->writeback_job->fb) {
WARN_ON(connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK);
- funcs->atomic_commit(connector, new_conn_state->writeback_job);
+ funcs->atomic_commit(connector, new_conn_state);
}
}
}
diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_modeset_helper_vtables.h
index 3b289773297c..fb841f44949c 100644
--- a/include/drm/drm_modeset_helper_vtables.h
+++ b/include/drm/drm_modeset_helper_vtables.h
@@ -980,11 +980,13 @@ struct drm_connector_helper_funcs {
*
* This hook is to be used by drivers implementing writeback connectors
* that need a point when to commit the writeback job to the hardware.
+ * The writeback_job to commit is available in
+ * &drm_connector_state.writeback_job.
*
* This callback is used by the atomic modeset helpers.
*/
void (*atomic_commit)(struct drm_connector *connector,
- struct drm_writeback_job *writeback_job);
+ struct drm_connector_state *state);
};
/**
--
2.14.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-07-03 7:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 7:50 [PATCH v4 0/8] drm/vc4: Add support for the transposer IP Boris Brezillon
2018-07-03 7:50 ` [PATCH v4 1/8] drm/atomic: Avoid connector to writeback_connector casts Boris Brezillon
2018-07-03 7:50 ` Boris Brezillon [this message]
2018-07-03 7:50 ` [PATCH v4 3/8] drm/connector: Make ->atomic_commit() optional Boris Brezillon
2018-07-03 7:50 ` [PATCH v4 4/8] drm/vc4: Use wait_for_flip_done() instead of wait_for_vblanks() Boris Brezillon
2018-07-03 7:50 ` [PATCH v4 5/8] drm/crtc: Add a generic infrastructure to fake VBLANK events Boris Brezillon
2018-07-03 7:50 ` [PATCH v4 6/8] drm/atomic: Call fake_vblank() from the generic commit_tail() helpers Boris Brezillon
2018-07-03 7:50 ` [PATCH v4 7/8] drm/vc4: Call drm_atomic_helper_fake_vblank() in the commit path Boris Brezillon
2018-07-03 7:50 ` [PATCH v4 8/8] drm/vc4: Add support for the transposer block Boris Brezillon
2018-07-07 6:25 ` [PATCH v4 0/8] drm/vc4: Add support for the transposer IP Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703075022.15138-3-boris.brezillon@bootlin.com \
--to=boris.brezillon@bootlin.com \
--cc=Liviu.Dudau@arm.com \
--cc=airlied@linux.ie \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.