From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Alan Stern <stern@rowland.harvard.edu>,
linux-pm@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bart Van Assche <bart.vanassche@wdc.com>,
Hannes Reinecke <hare@suse.de>,
Johannes Thumshirn <jthumshirn@suse.de>,
Adrian Hunter <adrian.hunter@intel.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH RFC V2 3/3] scsi_mq: enable runtime PM
Date: Tue, 17 Jul 2018 23:30:32 +0800 [thread overview]
Message-ID: <20180717153031.GA8973@ming.t460p> (raw)
In-Reply-To: <20180717132411.GI13582@lst.de>
On Tue, Jul 17, 2018 at 03:24:11PM +0200, Christoph Hellwig wrote:
> On Fri, Jul 13, 2018 at 04:06:02PM +0800, Ming Lei wrote:
> > Usually SCSI supports runtime PM, so pass BLK_MQ_F_SUPPORT_RPM to blk-mq
> > core for enabling block runtime PM.
>
> I still think enabling this unconditionally for any SCSI device was
> a mistake, and it is even more so for blk-mq.
>
> Please only opt in for ufs, ATA first, adding others if wanted by
> maintainers.
No, this way will cause regression because runtime PM works for
all sd/sr device actually, and it isn't related with scsi host.
Thanks,
Ming
next prev parent reply other threads:[~2018-07-17 15:30 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 8:05 [PATCH RFC V2 0/3] blk-mq: support runtime PM Ming Lei
2018-07-13 8:06 ` [PATCH RFC V2 1/3] block: put runtime PM code into common helpers Ming Lei
2018-07-17 13:21 ` Christoph Hellwig
2018-07-13 8:06 ` [PATCH RFC V2 2/3] blk-mq: prepare for supporting runtime PM Ming Lei
2018-07-13 20:16 ` Alan Stern
2018-07-17 13:23 ` Christoph Hellwig
2018-07-13 8:06 ` [PATCH RFC V2 3/3] scsi_mq: enable " Ming Lei
2018-07-17 13:24 ` Christoph Hellwig
2018-07-17 15:30 ` Ming Lei [this message]
2018-07-17 15:34 ` Bart Van Assche
2018-07-17 15:38 ` Ming Lei
2018-07-17 19:50 ` hch
2018-07-17 20:54 ` Alan Stern
2018-07-17 21:49 ` Jens Axboe
2018-07-18 12:06 ` Ming Lei
2018-07-18 12:28 ` Johannes Thumshirn
2018-07-18 12:37 ` Ming Lei
2018-07-18 14:12 ` Alan Stern
2018-07-18 14:18 ` Johannes Thumshirn
2018-07-18 15:01 ` Alan Stern
2018-07-19 6:41 ` Johannes Thumshirn
2018-07-19 14:35 ` Alan Stern
2018-07-19 14:43 ` Johannes Thumshirn
2018-07-18 14:50 ` Jens Axboe
2018-07-18 18:46 ` Alan Stern
2018-07-18 23:08 ` Ming Lei
2018-07-18 12:43 ` Hannes Reinecke
2018-07-18 13:05 ` Ming Lei
2018-07-13 14:21 ` [PATCH RFC V2 0/3] blk-mq: support " Jens Axboe
2018-07-14 2:37 ` Ming Lei
2018-07-14 2:54 ` Jens Axboe
2018-07-16 16:21 ` Bart Van Assche
2018-07-16 16:03 ` Bart Van Assche
2018-07-17 1:12 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717153031.GA8973@ming.t460p \
--to=ming.lei@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=rjw@rjwysocki.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.