Re: [PATCH] nfs: add minor version to nfs_server_key for fscache

From: Scott Mayhew <smayhew@redhat.com>
To: David Howells <dhowells@redhat.com>
Cc: trond.myklebust@hammerspace.com, anna.schumaker@netapp.com,
	linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfs: add minor version to nfs_server_key for fscache
Date: Wed, 18 Jul 2018 08:12:16 -0400	[thread overview]
Message-ID: <20180718121216.GK10135@coeurl.usersys.redhat.com> (raw)
In-Reply-To: <9138.1531475067@warthog.procyon.org.uk>

On Fri, 13 Jul 2018, David Howells wrote:

> Scott Mayhew <smayhew@redhat.com> wrote:
> 
> > kernel BUG at fs/cachefiles/namei.c:194!
> 
> Note that the cachefiles dumps a load of info immediately prior to this BUG()
> which should be included in the description.
> 
> Can you also try the four patches at the top of this branch from Kiran Kumar
> Modukuri?
> 
> 	https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=fscache-fixes
> 
> The topmost patch removes the BUG() and lets it fall through to the wait.  The
> "Fix missing clear of the CACHEFILES_OBJECT_ACTIVE flag" patch fixes one of
> the causes of the BUG.

With v4.18-rc5 plus those four patches, I no longer get the "Unexpected
object collision" message when running cthon (and no oops either,
obviously).

-Scott
> 
> David