From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Jacopo Mondi <jacopo@jmondi.org>
Cc: mchehab@kernel.org, laurent.pinchart@ideasonboard.com,
sam@elite-embedded.com, jagan@amarulasolutions.com,
festevam@gmail.com, pza@pengutronix.de,
steve_longerbeam@mentor.com, hugues.fruchet@st.com,
loic.poulain@linaro.org, daniel@zonque.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 1/2] media: ov5640: Fix timings setup code
Date: Wed, 18 Jul 2018 14:22:47 +0200 [thread overview]
Message-ID: <20180718122247.hpesu5sclolcfhfj@flea> (raw)
In-Reply-To: <1531912743-24767-2-git-send-email-jacopo@jmondi.org>
[-- Attachment #1: Type: text/plain, Size: 2006 bytes --]
On Wed, Jul 18, 2018 at 01:19:02PM +0200, Jacopo Mondi wrote:
> As of:
> commit 476dec012f4c ("media: ov5640: Add horizontal and vertical totals")
> the timings parameters gets programmed separately from the static register
> values array.
>
> When changing capture mode, the vertical and horizontal totals gets inspected
> by the set_mode_exposure_calc() functions, and only later programmed with the
> new values. This means exposure, light banding filter and shutter gain are
> calculated using the previous timings, and are thus not correct.
>
> Fix this by programming timings right after the static register value table
> has been sent to the sensor in the ov5640_load_regs() function.
>
> Fixes: 476dec012f4c ("media: ov5640: Add horizontal and vertical totals")
> Signed-off-by: Samuel Bobrowicz <sam@elite-embedded.com>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
>
> ---
> This fix has been circulating around for quite some time now, in Maxime clock
> tree patches, in Sam dropbox patches and in my latest MIPI fixes patches.
> While the rest of the series have not yet been accepted, there is general
> consensus this is an actual fix that has to be collected.
>
> I've slightly modified Sam's and Maxime's version I previously sent,
> programming timings directly in ov5640_load_regs() function.
> You can find Sam's previous version here:
> https://www.mail-archive.com/linux-media@vger.kernel.org/msg131654.html
> and mine here, with an additional change that aimed to fix MIPI mode, which
> I've left out in this version:
> https://www.mail-archive.com/linux-media@vger.kernel.org/msg133422.html
>
> Sam, Maxime, I took the liberty of taking your Signed-off-by from the previous
> patch, as this was spotted by you first. Is this ok with you?
Yep, thanks!
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-07-18 13:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 11:19 [PATCH 0/2] media: ov5640: Fix set_timings and auto-exposure Jacopo Mondi
2018-07-18 11:19 ` [PATCH 1/2] media: ov5640: Fix timings setup code Jacopo Mondi
2018-07-18 12:22 ` Maxime Ripard [this message]
2018-08-07 8:53 ` Hugues FRUCHET
2018-08-14 15:41 ` jacopo mondi
2018-07-18 11:19 ` [PATCH 2/2] media: ov5640: Fix auto-exposure disabling Jacopo Mondi
2018-07-18 13:04 ` jacopo mondi
2018-08-07 8:53 ` Hugues FRUCHET
2018-08-14 15:45 ` jacopo mondi
2018-09-06 17:08 ` Laurent Pinchart
2018-09-07 7:56 ` jacopo mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718122247.hpesu5sclolcfhfj@flea \
--to=maxime.ripard@bootlin.com \
--cc=daniel@zonque.org \
--cc=festevam@gmail.com \
--cc=hugues.fruchet@st.com \
--cc=jacopo@jmondi.org \
--cc=jagan@amarulasolutions.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mchehab@kernel.org \
--cc=pza@pengutronix.de \
--cc=sam@elite-embedded.com \
--cc=steve_longerbeam@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.