From: Christoph Hellwig <hch@infradead.org>
To: Huang Ying <ying.huang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Michal Hocko <mhocko@suse.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Shaohua Li <shli@kernel.org>, Hugh Dickins <hughd@google.com>,
Minchan Kim <minchan@kernel.org>, Rik van Riel <riel@redhat.com>,
Dan Williams <dan.j.williams@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Daniel Jordan <daniel.m.jordan@oracle.com>
Subject: Re: [PATCH v3 4/8] swap: Unify normal/huge code path in swap_page_trans_huge_swapped()
Date: Thu, 19 Jul 2018 05:40:13 -0700 [thread overview]
Message-ID: <20180719124013.GB28522@infradead.org> (raw)
In-Reply-To: <20180719084842.11385-5-ying.huang@intel.com>
> static inline bool cluster_is_huge(struct swap_cluster_info *info)
> {
> - return info->flags & CLUSTER_FLAG_HUGE;
> + if (IS_ENABLED(CONFIG_THP_SWAP))
> + return info->flags & CLUSTER_FLAG_HUGE;
> + else
> + return false;
Nitpick: no need for an else after a return:
if (IS_ENABLED(CONFIG_THP_SWAP))
return info->flags & CLUSTER_FLAG_HUGE;
return false;
next prev parent reply other threads:[~2018-07-19 12:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 8:48 [PATCH v3 0/8] swap: THP optimizing refactoring Huang Ying
2018-07-19 8:48 ` [PATCH v3 1/8] swap: Add comments to lock_cluster_or_swap_info() Huang Ying
2018-07-19 12:39 ` Christoph Hellwig
2018-07-20 0:27 ` Huang, Ying
2018-07-20 0:27 ` Huang, Ying
2018-07-19 8:48 ` [PATCH v3 2/8] mm/swapfile.c: Replace some #ifdef with IS_ENABLED() Huang Ying
2018-07-19 8:48 ` [PATCH v3 3/8] swap: Use swap_count() in swap_page_trans_huge_swapped() Huang Ying
2018-07-19 8:48 ` [PATCH v3 4/8] swap: Unify normal/huge code path " Huang Ying
2018-07-19 12:40 ` Christoph Hellwig [this message]
2018-07-20 0:26 ` Huang, Ying
2018-07-20 0:26 ` Huang, Ying
2018-07-19 8:48 ` [PATCH v3 5/8] swap: Unify normal/huge code path in put_swap_page() Huang Ying
2018-07-19 8:48 ` [PATCH v3 6/8] swap, get_swap_pages: Use entry_size instead of cluster in parameter Huang Ying
2018-07-19 8:48 ` [PATCH v3 7/8] swap: Add __swap_entry_free_locked() Huang Ying
2018-07-19 8:48 ` [PATCH v3 8/8] swap, put_swap_page: Share more between huge/normal code path Huang Ying
2018-07-19 20:21 ` [PATCH v3 0/8] swap: THP optimizing refactoring Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719124013.GB28522@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=daniel.m.jordan@oracle.com \
--cc=dave.hansen@linux.intel.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=shli@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.