Re: [PATCH v2 3/7] iio: tsl2772: add support for reading power settings from device tree

From: Brian Masney <masneyb@onstation.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	mark.rutland@arm.com, andy.gross@linaro.org,
	david.brown@linaro.org, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
	jonathan@marek.ca, jmaneyrol@invensense.com, knaack.h@gmx.de,
	lars@metafoo.de, pmeerw@pmeerw.net, mkelly@xevo.com,
	fischerdouglasc@gmail.com, bshah@kde.org, ctatlor97@gmail.com,
	drew.paterson@ams.com
Subject: Re: [PATCH v2 3/7] iio: tsl2772: add support for reading power settings from device tree
Date: Sun, 22 Jul 2018 12:37:20 +0000	[thread overview]
Message-ID: <20180722123720.GB20029@onstation.org> (raw)
In-Reply-To: <20180721183716.524632f1@archlinux>

On Sat, Jul 21, 2018 at 06:37:16PM +0100, Jonathan Cameron wrote:
> On Fri, 20 Jul 2018 11:36:35 -0600
> Rob Herring <robh@kernel.org> wrote:
> 
> > On Tue, Jul 17, 2018 at 04:41:54AM -0400, Brian Masney wrote:
> > > This patch adds support for optionally reading the prox_diode and
> > > prox_power settings from device tree. This was tested using a LG
> > > Nexus 5 (hammerhead) which requires a different diode than the driver
> > > default for the IR LED.
> > > 
> > > Signed-off-by: Brian Masney <masneyb@onstation.org>
> > > ---
> > > The next patch in the series removes the tsl2772 driver from the
> > > trivial-devices.txt file. I separated it out so that change can go
> > > through device tree.
> > > 
> > >  .../devicetree/bindings/iio/light/tsl2772.txt | 39 +++++++++++++++++++  
> > 
> > Please split DT bindings to separate patch.
> > 
> > >  drivers/iio/light/tsl2772.c                   | 16 ++++++++
> > >  include/dt-bindings/iio/amstaos,tsl2772.h     | 24 ++++++++++++
> > >  3 files changed, 79 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/iio/light/tsl2772.txt
> > >  create mode 100644 include/dt-bindings/iio/amstaos,tsl2772.h
> > > 
> > > diff --git a/Documentation/devicetree/bindings/iio/light/tsl2772.txt b/Documentation/devicetree/bindings/iio/light/tsl2772.txt
> > > new file mode 100644
> > > index 000000000000..ab553d52b9fc
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/iio/light/tsl2772.txt
> > > @@ -0,0 +1,39 @@
> > > +* AMS/TAOS ALS and proximity sensor
> > > +
> > > +Required properties:
> > > +
> > > +  - compatible: Should be one of
> > > +		"amstaos,tsl2571"
> > > +		"amstaos,tsl2671"
> > > +		"amstaos,tmd2671"
> > > +		"amstaos,tsl2771"
> > > +		"amstaos,tmd2771"
> > > +		"amstaos,tsl2572"
> > > +		"amstaos,tsl2672"
> > > +		"amstaos,tmd2672"
> > > +		"amstaos,tsl2772"
> > > +		"amstaos,tmd2772"
> > > +  - reg: the I2C address of the device
> > > +
> > > +Optional properties:
> > > +
> > > +  - amstaos,prox_diode - must be TSL2772_DIODE0, TSL2772_DIODE1, or
> > > +                         TSL2772_DIODE_BOTH.  
> > 
> > s/_/-/
> > 
> > > +  - amstaos,prox_power - must be TSL2772_100_mA, TSL2772_50_mA, TSL2772_25_mA,
> > > +                         or TSL2772_13_mA.  
> > 
> > I wonder if this should be common. Perhaps we should use the existing 
> > 'led-max-microamp' as this is setting the current for an IR LED.
> 
> Seems reasonable, then perhaps have two controls to turn on the diodes
> above.
> 
> > 
> > And while called 'power' this setting is current.
> 
> Also can we have real values?  I really don't like defines if they
> aren't absolutely necessary - particularly when there is a nice real
> unit to be used.

How about these options then?

amstaos,proximity-diode-0-enabled;
amstaos,proximity-diode-1-enabled;
led-max-microamp = <100000>;

Brian