Re: [PATCH v1] libnvdimm, namespace: Replace kmemdup() with kstrndup()

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Dave Jiang <dave.jiang@intel.com>,
	linux-nvdimm@lists.01.org
Subject: Re: [PATCH v1] libnvdimm, namespace: Replace kmemdup() with kstrndup()
Date: Thu, 30 Aug 2018 14:56:10 +0300	[thread overview]
Message-ID: <20180830115610.GN11447@smile.fi.intel.com> (raw)
In-Reply-To: <20180611134721.5862-1-andriy.shevchenko@linux.intel.com>

On Mon, Jun 11, 2018 at 04:47:21PM +0300, Andy Shevchenko wrote:
> kstrndup() takes care of '\0' terminator for the strings.
> 
> Use it here instead of kmemdup() + explicit terminating the input string.
> 

Any comments on this?

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/nvdimm/namespace_devs.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c
> index 28afdd668905..19525f025539 100644
> --- a/drivers/nvdimm/namespace_devs.c
> +++ b/drivers/nvdimm/namespace_devs.c
> @@ -270,11 +270,10 @@ static ssize_t __alt_name_store(struct device *dev, const char *buf,
>  	if (dev->driver || to_ndns(dev)->claim)
>  		return -EBUSY;
>  
> -	input = kmemdup(buf, len + 1, GFP_KERNEL);
> +	input = kstrndup(buf, len, GFP_KERNEL);
>  	if (!input)
>  		return -ENOMEM;
>  
> -	input[len] = '\0';
>  	pos = strim(input);
>  	if (strlen(pos) + 1 > NSLABEL_NAME_LEN) {
>  		rc = -EINVAL;
> -- 
> 2.17.1
> 

-- 
With Best Regards,
Andy Shevchenko

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm