From: Jonathan Cameron <jic23@kernel.org>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/5] iio: imu: st_lsm6dsx: add addr/max_word_len to st_lsm6dsx_read_block()
Date: Sun, 2 Sep 2018 21:29:37 +0100 [thread overview]
Message-ID: <20180902212937.0a9d1624@archlinux> (raw)
In-Reply-To: <20180830205259.7029-4-lorenzo.bianconi@redhat.com>
On Thu, 30 Aug 2018 22:52:57 +0200
Lorenzo Bianconi <lorenzo.bianconi@redhat.com> wrote:
> Add reg addr and max_word_len parameters to st_lsm6dsx_read_block
> since LSM6DSO will use a different register address to read samples
> from the FIFO and a different sample len
>
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Applied. Thanks
> ---
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c
> index 7e02935a4250..2002ba4a1abd 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c
> @@ -255,18 +255,18 @@ static int st_lsm6dsx_reset_hw_ts(struct st_lsm6dsx_hw *hw)
> * Set max bulk read to ST_LSM6DSX_MAX_WORD_LEN in order to avoid
> * a kmalloc for each bus access
> */
> -static inline int st_lsm6dsx_read_block(struct st_lsm6dsx_hw *hw, u8 *data,
> - unsigned int data_len)
> +static inline int st_lsm6dsx_read_block(struct st_lsm6dsx_hw *hw, u8 addr,
> + u8 *data, unsigned int data_len,
> + unsigned int max_word_len)
> {
> unsigned int word_len, read_len = 0;
> int err;
>
> while (read_len < data_len) {
> word_len = min_t(unsigned int, data_len - read_len,
> - ST_LSM6DSX_MAX_WORD_LEN);
> - err = regmap_bulk_read(hw->regmap,
> - ST_LSM6DSX_REG_FIFO_OUTL_ADDR,
> - data + read_len, word_len);
> + max_word_len);
> + err = regmap_bulk_read(hw->regmap, addr, data + read_len,
> + word_len);
> if (err < 0)
> return err;
> read_len += word_len;
> @@ -316,7 +316,9 @@ int st_lsm6dsx_read_fifo(struct st_lsm6dsx_hw *hw)
> gyro_sensor = iio_priv(hw->iio_devs[ST_LSM6DSX_ID_GYRO]);
>
> for (read_len = 0; read_len < fifo_len; read_len += pattern_len) {
> - err = st_lsm6dsx_read_block(hw, hw->buff, pattern_len);
> + err = st_lsm6dsx_read_block(hw, ST_LSM6DSX_REG_FIFO_OUTL_ADDR,
> + hw->buff, pattern_len,
> + ST_LSM6DSX_MAX_WORD_LEN);
> if (err < 0) {
> dev_err(hw->dev,
> "failed to read pattern from fifo (err=%d)\n",
prev parent reply other threads:[~2018-09-03 0:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 20:52 [PATCH 3/5] iio: imu: st_lsm6dsx: add addr/max_word_len to st_lsm6dsx_read_block() Lorenzo Bianconi
2018-09-02 20:29 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180902212937.0a9d1624@archlinux \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.