All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mst@redhat.com
Cc: kvm@vger.kernel.org, netdev@vger.kernel.org, glebfm@altlinux.org,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] vhost: fix VHOST_GET_BACKEND_FEATURES ioctl request definition
Date: Mon, 03 Sep 2018 21:23:43 -0700 (PDT)	[thread overview]
Message-ID: <20180903.212343.355534384554181027.davem__36127.7248980061$1536034906$gmane$org@davemloft.net> (raw)
In-Reply-To: <20180903231102-mutt-send-email-mst@kernel.org>

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Mon, 3 Sep 2018 23:11:11 -0400

> On Tue, Sep 04, 2018 at 11:08:40AM +0800, Jason Wang wrote:
>> 
>> 
>> On 2018年09月04日 10:22, Michael S. Tsirkin wrote:
>> > On Mon, Sep 03, 2018 at 08:59:13PM +0300, Gleb Fotengauer-Malinovskiy wrote:
>> > > The _IOC_READ flag fits this ioctl request more because this request
>> > > actually only writes to, but doesn't read from userspace.
>> > > See NOTEs in include/uapi/asm-generic/ioctl.h for more information.
>> > > 
>> > > Fixes: 429711aec282 ("vhost: switch to use new message format")
>> > > Signed-off-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>
>> > Hmm it does make sense, and it's not too late to fix this up.
>> > Jason, what's your take on this? Was _IOW intentional?
>> 
>> My bad, not intentional. And I agree that fixing this is not too late.
>> 
>> So
>> 
>> Acked-by: Jason Wang <jasowang@redhat.com>
> 
> 
> OK then
> 
> Acked-by: Michael S. Tsirkin <mst@redhat.com>

Applied, thanks everyone.

  parent reply	other threads:[~2018-09-04  4:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-03 17:59 [PATCH] vhost: fix VHOST_GET_BACKEND_FEATURES ioctl request definition Gleb Fotengauer-Malinovskiy
2018-09-04  2:22 ` Michael S. Tsirkin
2018-09-04  2:22   ` Michael S. Tsirkin
2018-09-04  3:08   ` Jason Wang
2018-09-04  3:11     ` Michael S. Tsirkin
2018-09-04  4:23       ` David Miller
2018-09-04  4:23       ` David Miller [this message]
2018-09-04  3:11     ` Michael S. Tsirkin
2018-09-04  3:08   ` Jason Wang
  -- strict thread matches above, loose matches on Subject: below --
2018-09-03 17:59 Gleb Fotengauer-Malinovskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20180903.212343.355534384554181027.davem__36127.7248980061$1536034906$gmane$org@davemloft.net' \
    --to=davem@davemloft.net \
    --cc=glebfm@altlinux.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.