All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jann Horn <jannh@google.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 13/17] compat_ioctl: remove /dev/random commands
Date: Wed, 12 Sep 2018 17:13:05 +0200	[thread overview]
Message-ID: <20180912151422.571531-4-arnd@arndb.de> (raw)
In-Reply-To: <20180912151422.571531-1-arnd@arndb.de>

These are all handled by the random driver, so instead of listing
each ioctl, we can just use the same function to deal with both
native and compat commands.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/char/random.c | 1 +
 fs/compat_ioctl.c     | 7 -------
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/char/random.c b/drivers/char/random.c
index bf5f99fc36f1..d1b2cdebc598 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -2021,6 +2021,7 @@ const struct file_operations random_fops = {
 	.write = random_write,
 	.poll  = random_poll,
 	.unlocked_ioctl = random_ioctl,
+	.compat_ioctl = generic_compat_ioctl_ptrarg,
 	.fasync = random_fasync,
 	.llseek = noop_llseek,
 };
diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c
index ca7f83976a3f..d5b8380fb1b1 100644
--- a/fs/compat_ioctl.c
+++ b/fs/compat_ioctl.c
@@ -764,13 +764,6 @@ COMPATIBLE_IOCTL(WDIOC_SETTIMEOUT)
 COMPATIBLE_IOCTL(WDIOC_GETTIMEOUT)
 COMPATIBLE_IOCTL(WDIOC_SETPRETIMEOUT)
 COMPATIBLE_IOCTL(WDIOC_GETPRETIMEOUT)
-/* Big R */
-COMPATIBLE_IOCTL(RNDGETENTCNT)
-COMPATIBLE_IOCTL(RNDADDTOENTCNT)
-COMPATIBLE_IOCTL(RNDGETPOOL)
-COMPATIBLE_IOCTL(RNDADDENTROPY)
-COMPATIBLE_IOCTL(RNDZAPENTCNT)
-COMPATIBLE_IOCTL(RNDCLEARPOOL)
 /* Bluetooth */
 COMPATIBLE_IOCTL(HCIDEVUP)
 COMPATIBLE_IOCTL(HCIDEVDOWN)
-- 
2.18.0


  parent reply	other threads:[~2018-09-12 15:15 UTC|newest]

Thread overview: 141+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-12 15:01 [PATCH v2 01/17] compat_ioctl: add generic_compat_ioctl_ptrarg() Arnd Bergmann
2018-09-12 15:01 ` [PATCH v2 02/17] compat_ioctl: move drivers to generic_compat_ioctl_ptrarg Arnd Bergmann
2018-09-12 15:01   ` [v2,02/17] " Arnd Bergmann
2018-09-12 15:01   ` [PATCH v2 02/17] " Arnd Bergmann
2018-09-12 15:01   ` Arnd Bergmann
2018-09-12 15:33   ` Jason Gunthorpe
2018-09-12 15:33     ` [v2,02/17] " Jason Gunthorpe
2018-09-12 15:33     ` [PATCH v2 02/17] " Jason Gunthorpe
2018-09-12 16:20     ` Arnd Bergmann
2018-09-12 16:20       ` [v2,02/17] " Arnd Bergmann
2018-09-12 16:20       ` [PATCH v2 02/17] " Arnd Bergmann
2018-09-12 16:20       ` Arnd Bergmann
2018-09-12 16:20     ` Arnd Bergmann
2018-09-12 18:13   ` Greg Kroah-Hartman
2018-09-12 18:13     ` [v2,02/17] " Greg Kroah-Hartman
2018-09-12 18:13     ` [PATCH v2 02/17] " Greg Kroah-Hartman
2018-09-16 19:07   ` Jarkko Sakkinen
2018-09-16 19:07     ` [v2,02/17] " Jarkko Sakkinen
2018-09-16 19:07     ` [PATCH v2 02/17] " Jarkko Sakkinen
2018-09-16 19:07     ` Jarkko Sakkinen
2018-09-12 15:01 ` Arnd Bergmann
2018-09-12 15:01 ` [PATCH v2 03/17] compat_ioctl: use correct compat_ptr() translation in drivers Arnd Bergmann
2018-09-12 15:01   ` [v2,03/17] " Arnd Bergmann
2018-09-12 18:13   ` [PATCH v2 03/17] " Greg Kroah-Hartman
2018-09-12 18:13     ` [v2,03/17] " Greg Kroah-Hartman
2018-09-13  0:48   ` [PATCH v2 03/17] " Andrew Donnellan
2018-09-13  0:48     ` [v2,03/17] " Andrew Donnellan
2018-09-13 11:03   ` [PATCH v2 03/17] " Felipe Balbi
2018-09-13 11:03     ` Felipe Balbi
2018-09-13 11:03     ` [v2,03/17] " Felipe Balbi
2018-09-12 15:01 ` [PATCH v2 04/17] ceph: fix compat_ioctl for ceph_dir_operations Arnd Bergmann
2018-09-12 16:12   ` David Laight
2018-09-12 16:25     ` Arnd Bergmann
2018-09-13  0:48   ` Yan, Zheng
2018-09-12 15:08 ` [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg Arnd Bergmann
2018-09-12 15:08   ` Arnd Bergmann
2018-09-12 15:08   ` [v2,05/17] " Arnd Bergmann
2018-09-12 15:08   ` [PATCH v2 05/17] " Arnd Bergmann
2018-09-12 15:08   ` Arnd Bergmann
2018-09-12 15:08   ` [PATCH v2 06/17] compat_ioctl: move rtc handling into rtc-dev.c Arnd Bergmann
2018-09-12 20:00     ` Alexandre Belloni
2018-09-12 15:08   ` [PATCH v2 07/17] compat_ioctl: move tape handling into drivers Arnd Bergmann
2018-09-12 15:08   ` [PATCH v2 08/17] compat_ioctl: remove keyboard ioctl translation Arnd Bergmann
2018-09-12 15:08   ` [PATCH v2 09/17] compat_ioctl: remove HIDIO translation Arnd Bergmann
2018-09-12 15:56   ` [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg Jason Gunthorpe
2018-09-12 15:56     ` Jason Gunthorpe
2018-09-12 15:56     ` [v2,05/17] " Jason Gunthorpe
2018-09-12 15:56     ` [PATCH v2 05/17] " Jason Gunthorpe
2018-09-12 15:58   ` Daniel Vetter
2018-09-12 15:58     ` Daniel Vetter
2018-09-12 15:58     ` [v2,05/17] " Daniel Vetter
2018-09-12 15:58     ` [PATCH v2 05/17] " Daniel Vetter
2018-09-12 15:58     ` Daniel Vetter
2018-09-12 15:58     ` Daniel Vetter
2018-09-12 15:58     ` Daniel Vetter
2018-09-12 16:01   ` Mauro Carvalho Chehab
2018-09-12 16:01     ` Mauro Carvalho Chehab
2018-09-12 16:01     ` [v2,05/17] " Mauro Carvalho Chehab
2018-09-12 16:01     ` [PATCH v2 05/17] " Mauro Carvalho Chehab
2018-09-12 16:01     ` Mauro Carvalho Chehab
2018-09-12 16:01     ` Mauro Carvalho Chehab
2018-09-12 18:13   ` Greg Kroah-Hartman
2018-09-12 18:13     ` Greg Kroah-Hartman
2018-09-12 18:13     ` Greg Kroah-Hartman
2018-09-12 18:13     ` [v2,05/17] " Greg Kroah-Hartman
2018-09-12 18:13     ` [PATCH v2 05/17] " Greg Kroah-Hartman
2018-09-12 18:13     ` Greg Kroah-Hartman
2018-09-12 18:13     ` Greg Kroah-Hartman
2018-09-14 14:23   ` David Sterba
2018-09-14 14:23     ` David Sterba
2018-09-14 14:23     ` [v2,05/17] " David Sterba
2018-09-14 14:23     ` [PATCH v2 05/17] " David Sterba
2018-09-14 14:23     ` David Sterba
2018-09-14 20:35   ` Darren Hart
2018-09-14 20:35     ` Darren Hart
2018-09-14 20:35     ` [v2,05/17] " Darren Hart
2018-09-14 20:35     ` [PATCH v2 05/17] " Darren Hart
2018-09-14 20:35     ` Darren Hart
2018-09-14 20:57     ` Al Viro
2018-09-14 20:57       ` Al Viro
2018-09-14 20:57       ` [v2,05/17] " Al Viro
2018-09-14 20:57       ` [PATCH v2 05/17] " Al Viro
2018-09-14 20:57       ` Al Viro
2018-09-18 17:51       ` Darren Hart
2018-09-18 17:51         ` Darren Hart
2018-09-18 17:51         ` [v2,05/17] " Darren Hart
2018-09-18 17:51         ` [PATCH v2 05/17] " Darren Hart
2018-09-18 17:51         ` Darren Hart
2018-09-18 17:59         ` Jason Gunthorpe
2018-09-18 17:59           ` Jason Gunthorpe
2018-09-18 17:59           ` [v2,05/17] " Jason Gunthorpe
2018-09-18 17:59           ` [PATCH v2 05/17] " Jason Gunthorpe
2018-09-24 20:18           ` Arnd Bergmann
2018-09-24 20:18             ` Arnd Bergmann
2018-09-24 20:18             ` [v2,05/17] " Arnd Bergmann
2018-09-24 20:18             ` [PATCH v2 05/17] " Arnd Bergmann
2018-09-24 20:18             ` Arnd Bergmann
2018-09-24 20:18             ` Arnd Bergmann
2018-09-24 20:18             ` Arnd Bergmann
2018-09-24 20:35             ` Jason Gunthorpe
2018-09-24 20:35               ` Jason Gunthorpe
2018-09-24 20:35               ` [v2,05/17] " Jason Gunthorpe
2018-09-24 20:35               ` [PATCH v2 05/17] " Jason Gunthorpe
2018-09-24 20:35               ` Jason Gunthorpe
2018-09-24 21:17               ` Arnd Bergmann
2018-09-24 21:17                 ` Arnd Bergmann
2018-09-24 21:17                 ` [v2,05/17] " Arnd Bergmann
2018-09-24 21:17                 ` [PATCH v2 05/17] " Arnd Bergmann
2018-09-24 21:17                 ` Arnd Bergmann
2018-09-24 21:17                 ` Arnd Bergmann
2018-09-24 21:17                 ` Arnd Bergmann
2018-09-17  9:33   ` Jonathan Cameron
2018-09-17  9:33     ` Jonathan Cameron
2018-09-17  9:33     ` [v2,05/17] " Jonathan Cameron
2018-09-17  9:33     ` [PATCH v2 05/17] " Jonathan Cameron
2018-09-17  9:33     ` Jonathan Cameron
2018-09-17  9:33     ` Jonathan Cameron
2018-10-06  7:05   ` Bjorn Andersson
2018-10-06  7:05     ` Bjorn Andersson
2018-10-06  7:05     ` Bjorn Andersson
2018-10-06  7:05     ` [v2,05/17] " Bjorn Andersson
2018-10-06  7:05     ` [PATCH v2 05/17] " Bjorn Andersson
2018-10-06  7:05     ` Bjorn Andersson
2018-09-12 15:13 ` [PATCH v2 10/17] compat_ioctl: remove translation for sound ioctls Arnd Bergmann
2018-09-12 15:13   ` Arnd Bergmann
2018-09-12 15:13   ` Arnd Bergmann
2018-09-12 15:13   ` [PATCH v2 11/17] compat_ioctl: remove isdn ioctl translation Arnd Bergmann
2018-09-12 15:13   ` [PATCH v2 12/17] compat_ioctl: remove IGNORE_IOCTL() Arnd Bergmann
2018-09-12 15:13   ` Arnd Bergmann [this message]
2018-09-12 18:13     ` [PATCH v2 13/17] compat_ioctl: remove /dev/random commands Greg Kroah-Hartman
2018-09-12 15:13   ` [PATCH v2 14/17] compat_ioctl: remove joystick ioctl translation Arnd Bergmann
2018-09-12 15:13   ` [PATCH v2 15/17] compat_ioctl: remove PCI " Arnd Bergmann
2018-09-12 15:13   ` [PATCH v2 16/17] compat_ioctl: remove /dev/raw " Arnd Bergmann
2018-09-12 15:13   ` [PATCH v2 17/17] compat_ioctl: remove last RAID handling code Arnd Bergmann
2018-09-13 13:37   ` [PATCH v2 10/17] compat_ioctl: remove translation for sound ioctls Takashi Iwai
2018-09-13 13:37     ` Takashi Iwai
2018-09-13 13:37     ` Takashi Iwai
2018-09-13  2:07 ` [PATCH v2 01/17] compat_ioctl: add generic_compat_ioctl_ptrarg() Al Viro
2018-09-13 10:29   ` Arnd Bergmann
2018-10-28 17:07     ` Al Viro
2018-10-29  9:50       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180912151422.571531-4-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jannh@google.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.