From: David Sterba <dsterba@suse.cz>
To: Liu Bo <bo.liu@linux.alibaba.com>
Cc: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: skip set_page_dirty if eb is dirty
Date: Thu, 13 Sep 2018 13:29:59 +0200 [thread overview]
Message-ID: <20180913112959.GT2154@twin.jikos.cz> (raw)
In-Reply-To: <20180912192745.elkmdpl5hyrawxks@US-160370MP2.local>
On Wed, Sep 12, 2018 at 12:27:46PM -0700, Liu Bo wrote:
> On Wed, Sep 12, 2018 at 09:37:20AM +0300, Nikolay Borisov wrote:
> >
> >
> > On 12.09.2018 01:06, Liu Bo wrote:
> > > As long as @eb is marked with EXTENT_BUFFER_DIRTY, all of its pages
> > > are dirty, so no need to set pages dirty again.
> > >
> > > Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
> >
> > Does make it any performance difference, numbers?
> >
>
> To be honest, the performance difference would be trivial in a normal
> big test round. But I just looked into the difference from my ftrace,
> removing the loop can reduce the time spent by 10us in my box.
10us was for the case where the pages were dirty already and the for
cycle was then skipped?
set_page_dirty is not lightweight, calls down to various functions and
holds locks. I can't tell if this is still fast enough on your machine
so that it really takes 10us.
The conditional dirtying is definetelly worth though,
Reviewed-by: David Sterba <dsterba@suse.com>
next prev parent reply other threads:[~2018-09-13 16:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 22:06 [PATCH] Btrfs: skip set_page_dirty if eb is dirty Liu Bo
2018-09-12 6:37 ` Nikolay Borisov
2018-09-12 19:27 ` Liu Bo
2018-09-13 11:29 ` David Sterba [this message]
2018-09-13 16:54 ` Liu Bo
2018-09-13 17:44 ` [PATCH v2] " Liu Bo
2018-09-14 6:30 ` Nikolay Borisov
2018-09-14 12:59 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180913112959.GT2154@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=bo.liu@linux.alibaba.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.