All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liu Bo <bo.liu@linux.alibaba.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: remove wait_ordered_range in btrfs_evict_inode
Date: Fri, 14 Sep 2018 12:16:44 -0700	[thread overview]
Message-ID: <20180914191643.tsxkyh2jvkymiie2@US-160370MP2.local> (raw)
In-Reply-To: <20180914131433.GD5847@twin.jikos.cz>

On Fri, Sep 14, 2018 at 03:14:33PM +0200, David Sterba wrote:
> On Wed, Sep 12, 2018 at 06:06:22AM +0800, Liu Bo wrote:
> > As VFS has called ->invalidatepage() to get all ordered extents done
> > and truncated all page cache pages, wait_ordered_range() is just a
> > noop.
> 
> Agreed, though looking up the exact points when there are no pages to be
> waited for took me some time. More references and hints in the changelog
> would be good. I'll add the patch to misc-next so it can be tested, but
> please send me an update if you have idea how to rephrase the changelog.
> Thanks.
> 
> Reviewed-by: David Sterba <dsterba@suse.com>

OK, I'll add some call stack, hopefully can make it better.

thanks,
-liubo

  reply	other threads:[~2018-09-15  0:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-11 22:06 [PATCH] Btrfs: remove wait_ordered_range in btrfs_evict_inode Liu Bo
2018-09-14 13:14 ` David Sterba
2018-09-14 19:16   ` Liu Bo [this message]
2018-09-14 21:03 ` [PATCH v2] Btrfs: remove wait_ordered_rane " Liu Bo
2018-09-21 15:29   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180914191643.tsxkyh2jvkymiie2@US-160370MP2.local \
    --to=bo.liu@linux.alibaba.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.