From: Peter Zijlstra <peterz@infradead.org>
To: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
konrad.wilk@oracle.com, x86@kernel.org, dwmw@amazon.co.uk,
tglx@linutronix.de,
Srinivas REDDY Eeda <srinivas.eeda@oracle.com>,
bp@suse.de, hpa@zytor.com, dhaval.giani@oracle.com
Subject: Re: [PATCH] x86/speculation: Use AMD specific retpoline for inline asm on AMD
Date: Tue, 18 Sep 2018 15:03:16 +0200 [thread overview]
Message-ID: <20180918130316.GP24142@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180918130058.GM24106@hirez.programming.kicks-ass.net>
> > In original code, it will go to "call *%[thunk_target]\n" while
> > we have set SPECTRE_V2_RETPOLINE_MINIMAL or
> > SPECTRE_V2_RETPOLINE_MINIMAL_AMD. Is this expected?
>
> Yes, that is exactly right -- it does that with or without your change
> though.
Soryr, I wrote that before I noticed the CONFIG_RETPOLINE vs RETPOLINE
thing.
In any case, since retpoline capable compilers are widely available, I'm
all for making CONFIG_RETPOLINE hard depend on it. That minimal stuff
really is quite silly.
next prev parent reply other threads:[~2018-09-18 13:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 5:17 [PATCH] x86/speculation: Use AMD specific retpoline for inline asm on AMD Zhenzhong Duan
2018-09-18 9:50 ` Peter Zijlstra
2018-09-18 10:31 ` Zhenzhong Duan
2018-09-18 10:59 ` Peter Zijlstra
2018-09-18 12:04 ` Zhenzhong Duan
2018-09-18 13:00 ` Peter Zijlstra
2018-09-18 13:03 ` Peter Zijlstra [this message]
2018-09-18 13:32 ` David Woodhouse
2018-09-18 14:41 ` Zhenzhong Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180918130316.GP24142@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@suse.de \
--cc=dhaval.giani@oracle.com \
--cc=dwmw@amazon.co.uk \
--cc=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=srinivas.eeda@oracle.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zhenzhong.duan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.