All of lore.kernel.org
 help / color / mirror / Atom feed
From: YueHaibing <yuehaibing@huawei.com>
To: davem@davemloft.net, dmitry.tarnyagin@lockless.no,
	wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com,
	hsweeten@visionengravers.com, madalin.bucur@nxp.com,
	pantelis.antoniou@gmail.com, claudiu.manoil@nxp.com,
	leoyang.li@nxp.com, linux@armlinux.org.uk, sammy@sammy.net,
	ralf@linux-mips.org, nico@fluxnic.net,
	steve.glendinning@shawell.net, f.fainelli@gmail.com,
	grygorii.strashko@ti.com, w-kwok2@ti.com, m-karicheri2@ti.com,
	t.sailer@alumni.ethz.ch, jreuter@yaina.de, kys@microsoft.com,
	haiyangz@microsoft.com, wei.liu2@citrix.com,
	paul.durrant@citrix.com, arvid.brodin@alten.se, pshelar@ovn.org
Cc: dev@openvswitch.org, linux-mips@linux-mips.org,
	xen-devel@lists.xenproject.org, netdev@vger.kernel.org,
	linux-usb@vger.kernel.org, YueHaibing <yuehaibing@huawei.com>,
	linux-kernel@vger.kernel.org, linux-can@vger.kernel.org,
	devel@linuxdriverproject.org, linux-hams@vger.kernel.org,
	linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next 17/22] hv_netvsc: fix return type of ndo_start_xmit function
Date: Thu, 20 Sep 2018 20:33:01 +0800	[thread overview]
Message-ID: <20180920123306.14772-18-yuehaibing__21704.9898616553$1537452466$gmane$org@huawei.com> (raw)
In-Reply-To: <20180920123306.14772-1-yuehaibing@huawei.com>

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.

Found by coccinelle.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/net/hyperv/netvsc_drv.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index 3af6d8d..056c472 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -511,7 +511,8 @@ static int netvsc_vf_xmit(struct net_device *net, struct net_device *vf_netdev,
 	return rc;
 }
 
-static int netvsc_start_xmit(struct sk_buff *skb, struct net_device *net)
+static netdev_tx_t
+netvsc_start_xmit(struct sk_buff *skb, struct net_device *net)
 {
 	struct net_device_context *net_device_ctx = netdev_priv(net);
 	struct hv_netvsc_packet *packet = NULL;
@@ -528,8 +529,11 @@ static int netvsc_start_xmit(struct sk_buff *skb, struct net_device *net)
 	 */
 	vf_netdev = rcu_dereference_bh(net_device_ctx->vf_netdev);
 	if (vf_netdev && netif_running(vf_netdev) &&
-	    !netpoll_tx_running(net))
-		return netvsc_vf_xmit(net, vf_netdev, skb);
+	    !netpoll_tx_running(net)) {
+		ret = netvsc_vf_xmit(net, vf_netdev, skb);
+		if (ret)
+			return NETDEV_TX_BUSY;
+	}
 
 	/* We will atmost need two pages to describe the rndis
 	 * header. We can only transmit MAX_PAGE_BUFFER_COUNT number
-- 
1.8.3.1



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2018-09-20 12:48 UTC|newest]

Thread overview: 191+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-20 12:32 [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function YueHaibing
2018-09-20 12:32 ` YueHaibing
2018-09-20 12:32 ` YueHaibing
2018-09-20 12:32 ` [PATCH net-next 01/22] net: micrel: " YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32   ` [net-next,01/22] " YueHaibing
2018-09-20 12:32   ` [PATCH net-next 01/22] " YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32 ` YueHaibing
2018-09-20 12:32 ` [PATCH net-next 02/22] net: freescale: " YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32   ` [net-next,02/22] " YueHaibing
2018-09-20 12:32   ` [PATCH net-next 02/22] " YueHaibing
2018-09-20 12:32 ` YueHaibing
2018-09-20 12:32 ` [PATCH net-next 03/22] net: seeq: " YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32   ` [net-next,03/22] " YueHaibing
2018-09-20 12:32   ` [PATCH net-next 03/22] " YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32 ` YueHaibing
2018-09-20 12:32 ` [PATCH net-next 04/22] net: cirrus: " YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32   ` [net-next,04/22] " YueHaibing
2018-09-20 12:32   ` [PATCH net-next 04/22] " YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32 ` YueHaibing
2018-09-20 12:32 ` [PATCH net-next 05/22] net: sgi: " YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32   ` [net-next,05/22] " YueHaibing
2018-09-20 12:32   ` [PATCH net-next 05/22] " YueHaibing
2018-09-20 12:32 ` YueHaibing
2018-09-20 12:32 ` [PATCH net-next 06/22] net: wiznet: " YueHaibing
2018-09-20 12:32 ` YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32   ` [net-next,06/22] " YueHaibing
2018-09-20 12:32   ` [PATCH net-next 06/22] " YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32 ` [PATCH net-next 07/22] net: i825xx: " YueHaibing
2018-09-20 12:32 ` YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32   ` [net-next,07/22] " YueHaibing
2018-09-20 12:32   ` [PATCH net-next 07/22] " YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32 ` [PATCH net-next 08/22] net: apple: " YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32   ` [net-next,08/22] " YueHaibing
2018-09-20 12:32   ` [PATCH net-next 08/22] " YueHaibing
2018-09-20 12:32 ` YueHaibing
2018-09-20 12:32 ` [PATCH net-next 09/22] net: smsc: " YueHaibing
2018-09-20 12:32 ` YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32   ` [net-next,09/22] " YueHaibing
2018-09-20 12:32   ` [PATCH net-next 09/22] " YueHaibing
2018-09-20 12:32 ` [PATCH net-next 10/22] net: ti: " YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32   ` [net-next,10/22] " YueHaibing
2018-09-20 12:32   ` [PATCH net-next 10/22] " YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32 ` YueHaibing
2018-09-20 12:32 ` [PATCH net-next 11/22] net: faraday: " YueHaibing
2018-09-20 12:32 ` YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32   ` [net-next,11/22] " YueHaibing
2018-09-20 12:32   ` [PATCH net-next 11/22] " YueHaibing
2018-09-20 12:32 ` [PATCH net-next 12/22] net: ovs: " YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32   ` [net-next,12/22] " YueHaibing
2018-09-20 12:32   ` [PATCH net-next 12/22] " YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32 ` YueHaibing
2018-09-20 12:32 ` [PATCH net-next 13/22] net: xen-netback: " YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32   ` [net-next,13/22] " YueHaibing
2018-09-20 12:32   ` [PATCH net-next 13/22] " YueHaibing
2018-09-20 14:05   ` Wei Liu
2018-09-20 14:05     ` Wei Liu
2018-09-20 14:05     ` Wei Liu
2018-09-20 14:05     ` [net-next,13/22] " Wei Liu
2018-09-20 14:05     ` [PATCH net-next 13/22] " Wei Liu
2018-09-20 14:05     ` Wei Liu
2018-09-20 14:05   ` Wei Liu
2018-09-20 12:32 ` YueHaibing
2018-09-20 12:32 ` [PATCH net-next 14/22] net: caif: " YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32   ` [net-next,14/22] " YueHaibing
2018-09-20 12:32   ` [PATCH net-next 14/22] " YueHaibing
2018-09-20 12:32 ` YueHaibing
2018-09-20 12:32 ` [PATCH net-next 15/22] net: hamradio: " YueHaibing
2018-09-20 12:32 ` YueHaibing
2018-09-20 12:32   ` YueHaibing
2018-09-20 12:32   ` [net-next,15/22] " YueHaibing
2018-09-20 12:32   ` [PATCH net-next 15/22] " YueHaibing
2018-09-20 12:33 ` [PATCH net-next 16/22] usbnet: ipheth: " YueHaibing
2018-09-20 12:33   ` YueHaibing
2018-09-20 12:33   ` [net-next,16/22] " YueHaibing
2018-09-20 12:33   ` [PATCH net-next 16/22] " YueHaibing
2018-09-20 12:33 ` YueHaibing
2018-09-20 12:33 ` YueHaibing [this message]
2018-09-20 12:33 ` [PATCH net-next 17/22] hv_netvsc: " YueHaibing
2018-09-20 12:33   ` YueHaibing
2018-09-20 12:33   ` YueHaibing
2018-09-20 12:33   ` [net-next,17/22] " YueHaibing
2018-09-20 12:33   ` [PATCH net-next 17/22] " YueHaibing
2018-09-20 12:33   ` YueHaibing
2018-09-20 14:40   ` Haiyang Zhang
2018-09-20 14:40     ` Haiyang Zhang
2018-09-20 14:40     ` Haiyang Zhang
2018-09-20 14:40     ` Haiyang Zhang
2018-09-20 14:40     ` [net-next,17/22] " Haiyang Zhang
2018-09-20 14:40     ` [PATCH net-next 17/22] " Haiyang Zhang
2018-09-20 14:40     ` Haiyang Zhang
2018-09-20 14:40   ` Haiyang Zhang
2018-09-20 14:43   ` Stephen Hemminger
2018-09-20 14:43   ` Stephen Hemminger
2018-09-20 14:43     ` Stephen Hemminger
2018-09-20 14:43     ` Stephen Hemminger
2018-09-20 14:43     ` [net-next,17/22] " Stephen Hemminger
2018-09-20 14:43     ` [PATCH net-next 17/22] " Stephen Hemminger
2018-09-20 14:43     ` Stephen Hemminger
2018-09-20 14:50     ` Haiyang Zhang
2018-09-20 14:50     ` Haiyang Zhang via dev
2018-09-20 14:50       ` Haiyang Zhang
2018-09-20 14:50       ` Haiyang Zhang
2018-09-20 14:50       ` Haiyang Zhang
2018-09-20 14:50       ` Haiyang Zhang
2018-09-20 14:50       ` Haiyang Zhang via dev
2018-09-21  1:35       ` YueHaibing
2018-09-21  1:35         ` YueHaibing
2018-09-21  1:35         ` YueHaibing
2018-09-21  1:35         ` YueHaibing
2018-09-21  1:35         ` YueHaibing
2018-09-21  1:35       ` YueHaibing
2018-09-21  1:37     ` YueHaibing
2018-09-21  1:37     ` YueHaibing
2018-09-21  1:37       ` YueHaibing
2018-09-21  1:37       ` YueHaibing
2018-09-21  1:37       ` [net-next,17/22] " YueHaibing
2018-09-21  1:37       ` [PATCH net-next 17/22] " YueHaibing
2018-09-21  1:37       ` YueHaibing
2018-09-20 12:33 ` [PATCH net-next 18/22] can: xilinx: " YueHaibing
2018-09-20 12:33   ` YueHaibing
2018-09-20 12:33   ` [net-next,18/22] " YueHaibing
2018-09-20 12:33   ` [PATCH net-next 18/22] " YueHaibing
2018-09-20 12:33 ` YueHaibing
2018-09-20 12:33 ` [PATCH net-next 19/22] net: plip: " YueHaibing
2018-09-20 12:33 ` YueHaibing
2018-09-20 12:33   ` YueHaibing
2018-09-20 12:33   ` [net-next,19/22] " YueHaibing
2018-09-20 12:33   ` [PATCH net-next 19/22] " YueHaibing
2018-09-20 12:33 ` [PATCH net-next 20/22] rionet: " YueHaibing
2018-09-20 12:33   ` YueHaibing
2018-09-20 12:33   ` [net-next,20/22] " YueHaibing
2018-09-20 12:33   ` [PATCH net-next 20/22] " YueHaibing
2018-09-20 12:33 ` YueHaibing
2018-09-20 12:33 ` [PATCH net-next 21/22] l2tp: " YueHaibing
2018-09-20 12:33   ` YueHaibing
2018-09-20 12:33   ` YueHaibing
2018-09-20 12:33   ` [net-next,21/22] " YueHaibing
2018-09-20 12:33   ` [PATCH net-next 21/22] " YueHaibing
2018-09-20 12:33   ` YueHaibing
2018-09-20 12:33 ` YueHaibing
2018-09-20 12:33 ` [PATCH net-next 22/22] net: hsr: " YueHaibing
2018-09-20 12:33 ` YueHaibing
2018-09-20 12:33   ` YueHaibing
2018-09-20 12:33   ` YueHaibing
2018-09-20 12:33   ` [net-next,22/22] " YueHaibing
2018-09-20 12:33   ` [PATCH net-next 22/22] " YueHaibing
2018-09-20 12:33   ` YueHaibing
2018-09-20 15:50 ` [PATCH net-next 00/22] net: " David Miller
2018-09-20 15:50   ` David Miller
2018-09-20 15:50   ` David Miller
2018-09-21  1:33   ` YueHaibing
2018-09-21  1:33     ` YueHaibing
2018-09-21  1:33     ` YueHaibing
2018-09-21  1:33     ` YueHaibing
2018-09-21  1:33     ` YueHaibing
2018-09-21  1:33   ` YueHaibing
2018-09-20 15:50 ` David Miller
2018-09-20 17:04 ` Grygorii Strashko
2018-09-20 17:04   ` Grygorii Strashko
2018-09-20 17:04   ` Grygorii Strashko
2018-09-20 17:04   ` Grygorii Strashko
2018-09-20 17:04   ` Grygorii Strashko
2018-09-20 17:04 ` Grygorii Strashko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20180920123306.14772-18-yuehaibing__21704.9898616553$1537452466$gmane$org@huawei.com' \
    --to=yuehaibing@huawei.com \
    --cc=arvid.brodin@alten.se \
    --cc=claudiu.manoil@nxp.com \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=devel@linuxdriverproject.org \
    --cc=dmitry.tarnyagin@lockless.no \
    --cc=f.fainelli@gmail.com \
    --cc=grygorii.strashko@ti.com \
    --cc=haiyangz@microsoft.com \
    --cc=hsweeten@visionengravers.com \
    --cc=jreuter@yaina.de \
    --cc=kys@microsoft.com \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-hams@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=m-karicheri2@ti.com \
    --cc=madalin.bucur@nxp.com \
    --cc=michal.simek@xilinx.com \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=nico@fluxnic.net \
    --cc=pantelis.antoniou@gmail.com \
    --cc=paul.durrant@citrix.com \
    --cc=pshelar@ovn.org \
    --cc=ralf@linux-mips.org \
    --cc=sammy@sammy.net \
    --cc=steve.glendinning@shawell.net \
    --cc=t.sailer@alumni.ethz.ch \
    --cc=w-kwok2@ti.com \
    --cc=wei.liu2@citrix.com \
    --cc=wg@grandegger.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.