Re: [RFC PATCH 7/9] leds: lm3633: Introduce the lm3633 driver

From: Pavel Machek <pavel@ucw.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: robh+dt@kernel.org, jacek.anaszewski@gmail.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	lee.jones@linaro.org, linux-omap@vger.kernel.org,
	linux-leds@vger.kernel.org
Subject: Re: [RFC PATCH 7/9] leds: lm3633: Introduce the lm3633 driver
Date: Thu, 27 Sep 2018 23:47:52 +0200	[thread overview]
Message-ID: <20180927214752.GG17346@amd> (raw)
In-Reply-To: <7da01c06-f0f1-9022-54ec-f851d01f86ee@ti.com>

[-- Attachment #1: Type: text/plain, Size: 757 bytes --]

Hi!

> > Duplicate.
> > 
> > Can we get some more sharing? One way would be to have struct with
> > all the constants (instead of #defines) use that...?
> 
> I will look at the adding common constants to but they should be common across
> more then just 2 devices.  As you can see the LM3632 code is quite different
> when you add in the flash/torch support.

LM3632 is indeed different, I see.

On the other hand, I'd really like to see the code shared, even if it
is just for 2 devices. (I believe that family is big enough that we'll
likely see more sharing in future).

Thanks,

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]