From: Simon Horman <horms@verge.net.au>
To: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Mark Rutland <mark.rutland@arm.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3 1/6] dt-bindings: mmc: renesas_sdhi: Add r8a77470 support
Date: Tue, 9 Oct 2018 11:48:18 +0200 [thread overview]
Message-ID: <20181009094817.7afnnwjjoecixbya@verge.net.au> (raw)
In-Reply-To: <1538988712-17077-2-git-send-email-fabrizio.castro@bp.renesas.com>
On Mon, Oct 08, 2018 at 09:51:47AM +0100, Fabrizio Castro wrote:
> The RZ/G1C (a.k.a. R8A77470) comes with three SDHI interfaces,
> SDHI0 and SDHI2 are compatible with R-Car Gen2 SDHIs, and
> SDHI1 is compatible with R-Car Gen3 SDHIs, as it comes with an
> internal DMAC, therefore SDHI1 is fully compatible with driver
> renesas_sdhi_internal_dmac driver. As a result, the compatible
> strings for the R8A77470 SDHI interfaces are a little bit special.
> Document SDHI support for the RZ/G1C SoC.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>
> ---
> v2->v3:
> * Incorporated comments from Geert
>
> v1->v2:
> * Added "renesas,sdhi-mmc-r8a77470"
> * Using generic/fallback compatibilty only for SDHI[02]
> * Reworked changelog
> ---
> Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
> index d39d5e4..27f2eab 100644
> --- a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
> +++ b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
> @@ -19,6 +19,8 @@ Required properties:
> "renesas,sdhi-r8a7744" - SDHI IP on R8A7744 SoC
> "renesas,sdhi-r8a7745" - SDHI IP on R8A7745 SoC
> "renesas,sdhi-r8a774a1" - SDHI IP on R8A774A1 SoC
> + "renesas,sdhi-r8a77470" - SDHI IP on R8A77470 SoC
> + "renesas,sdhi-mmc-r8a77470" - SDHI/MMC IP on R8A77470 SoC
> "renesas,sdhi-r8a7778" - SDHI IP on R8A7778 SoC
> "renesas,sdhi-r8a7779" - SDHI IP on R8A7779 SoC
> "renesas,sdhi-r8a7790" - SDHI IP on R8A7790 SoC
> @@ -35,8 +37,8 @@ Required properties:
> "renesas,sdhi-r8a77995" - SDHI IP on R8A77995 SoC
> "renesas,sdhi-shmobile" - a generic sh-mobile SDHI controller
> "renesas,rcar-gen1-sdhi" - a generic R-Car Gen1 SDHI controller
> - "renesas,rcar-gen2-sdhi" - a generic R-Car Gen2 or RZ/G1
> - SDHI controller
> + "renesas,rcar-gen2-sdhi" - a generic R-Car Gen2 and RZ/G1 SDHI
> + (not SDHI/MMC) controller
> "renesas,rcar-gen3-sdhi" - a generic R-Car Gen3 or RZ/G2
> SDHI controller
>
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-10-09 9:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 8:51 [PATCH v3 0/6] Add uSD and eMMC to iwg23s Fabrizio Castro
2018-10-08 8:51 ` [PATCH v3 1/6] dt-bindings: mmc: renesas_sdhi: Add r8a77470 support Fabrizio Castro
2018-10-09 9:48 ` Simon Horman [this message]
2018-10-12 14:53 ` Rob Herring
2018-10-12 14:53 ` Rob Herring
2018-10-15 13:15 ` Ulf Hansson
2018-10-08 8:51 ` [PATCH v3 2/6] pinctrl: sh-pfc: r8a77470: Add SDHI support Fabrizio Castro
2018-10-10 7:36 ` Geert Uytterhoeven
2018-10-10 9:26 ` Fabrizio Castro
2018-10-08 8:51 ` [PATCH v3 3/6] mmc: renesas_sdhi: Add r8a77470 SDHI1 support Fabrizio Castro
2018-10-15 13:15 ` Ulf Hansson
2018-10-08 8:51 ` [PATCH v3 4/6] ARM: dts: r8a77470: Add SDHI0 support Fabrizio Castro
2018-10-15 15:19 ` Simon Horman
2018-10-15 15:38 ` Simon Horman
2018-10-08 8:51 ` [PATCH v3 5/6] ARM: dts: r8a77470: Add SDHI1 support Fabrizio Castro
2018-10-15 15:38 ` Simon Horman
2018-10-08 8:51 ` [PATCH v3 6/6] ARM: dts: iwg23s-sbc: Add uSD and eMMC support Fabrizio Castro
2018-10-15 15:38 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009094817.7afnnwjjoecixbya@verge.net.au \
--to=horms@verge.net.au \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.