From: Tomas Winkler <tomas.winkler@intel.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Jason Gunthorpe <jgg@ziepe.ca>
Cc: Nayna Jain <nayna@linux.vnet.ibm.com>,
Alexander Usyskin <alexander.usyskin@intel.com>,
Tadeusz Struk <tadeusz.struk@intel.com>,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org,
Tomas Winkler <tomas.winkler@intel.com>
Subject: [PATCH v6 13/20] tpm: tpm-interface.c drop unused macros
Date: Wed, 17 Oct 2018 09:46:06 +0300 [thread overview]
Message-ID: <20181017064613.19746-14-tomas.winkler@intel.com> (raw)
In-Reply-To: <20181017064613.19746-1-tomas.winkler@intel.com>
The commit:
"tpm_tis: further simplify calculation of ordinal duration"
left unused macros, we can drop them now.
Fixes compilation warnings:
tpm-interface.c:37:0: warning: macro "TPM_PROTECTED_COMMAND" is not used [-Wunused-macros]
tpm-interface.c:36:0: warning: macro "TSC_MAX_ORDINAL" is not used [-Wunused-macros]
tpm-interface.c:38:0: warning: macro "TPM_CONNECTION_COMMAND" is not used [-Wunused-macros]
Fixes: f72864300139 ("tpm_tis: further simplify calculation of ordinal duration")
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
---
V3: New in the series.
V4: Fix the commit message.
V5-V6: Rebase
drivers/char/tpm/tpm-interface.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c
index 69e007a198ce..ba50554e34d3 100644
--- a/drivers/char/tpm/tpm-interface.c
+++ b/drivers/char/tpm/tpm-interface.c
@@ -33,10 +33,6 @@
#include "tpm.h"
-#define TSC_MAX_ORDINAL 12
-#define TPM_PROTECTED_COMMAND 0x00
-#define TPM_CONNECTION_COMMAND 0x40
-
/*
* Bug workaround - some TPM's don't flush the most
* recently changed pcr on suspend, so force the flush
--
2.14.4
next prev parent reply other threads:[~2018-10-17 6:50 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 6:45 [PATCH v6 00/21] tpm: separate tpm 1.x and tpm 2.x commands Tomas Winkler
2018-10-17 6:45 ` [PATCH v6 01/20] tpm2: add new tpm2 commands according to TCG 1.36 Tomas Winkler
2018-10-17 6:45 ` [PATCH v6 02/20] tpm: sort objects in the Makefile Tomas Winkler
2018-10-17 6:45 ` [PATCH v6 03/20] tpm: factor out tpm 1.x duration calculation to tpm1-cmd.c Tomas Winkler
2018-10-17 11:54 ` Nayna Jain
2018-10-17 11:54 ` Nayna Jain
2018-10-17 12:24 ` Winkler, Tomas
2018-10-17 12:24 ` Winkler, Tomas
2018-10-17 15:07 ` Nayna Jain
2018-10-17 15:28 ` Winkler, Tomas
2018-10-17 6:45 ` [PATCH v6 04/20] tpm: add tpm_calc_ordinal_duration() wrapper Tomas Winkler
2018-10-17 6:45 ` [PATCH v6 05/20] tpm: factor out tpm_get_timeouts() Tomas Winkler
2018-10-17 6:45 ` [PATCH v6 06/20] tpm: move tpm1_pcr_extend to tpm1-cmd.c Tomas Winkler
2018-10-17 6:45 ` Tomas Winkler
2018-10-17 6:46 ` [PATCH v6 07/20] tpm: move tpm_getcap " Tomas Winkler
2018-10-17 6:46 ` Tomas Winkler
2018-10-17 6:46 ` [PATCH v6 08/20] tpm: factor out tpm1_get_random into tpm1-cmd.c Tomas Winkler
2018-10-17 6:46 ` [PATCH v6 09/20] tpm: move tpm 1.x selftest code from tpm-interface.c tpm1-cmd.c Tomas Winkler
2018-10-17 6:46 ` [PATCH v6 10/20] tpm: factor out tpm 1.x pm suspend flow into tpm1-cmd.c Tomas Winkler
2018-10-17 6:46 ` [PATCH v6 11/20] tpm: factor out tpm_startup function Tomas Winkler
2018-10-17 6:46 ` [PATCH v6 12/20] tpm: add tpm_auto_startup() into tpm-interface.c Tomas Winkler
2018-10-17 6:46 ` Tomas Winkler [this message]
2018-10-17 6:46 ` [PATCH v6 14/20] tpm: tpm-space.c remove unneeded semicolon Tomas Winkler
2018-10-17 6:46 ` [PATCH v6 15/20] tpm: tpm1: rewrite tpm1_get_random() using tpm_buf structure Tomas Winkler
2018-10-17 6:46 ` [PATCH v6 16/20] tpm1: implement tpm1_pcr_read_dev() " Tomas Winkler
2018-10-17 6:46 ` [PATCH v6 17/20] tmp1: rename tpm1_pcr_read_dev to tpm1_pcr_read() Tomas Winkler
2018-10-17 6:46 ` [PATCH v6 18/20] tpm1: reimplement SAVESTATE using tpm_buf Tomas Winkler
2018-10-17 6:46 ` [PATCH v6 19/20] tpm1: reimplement tpm1_continue_selftest() " Tomas Winkler
2018-10-17 6:46 ` [PATCH v6 20/20] tpm: use u32 instead of int for PCR index Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017064613.19746-14-tomas.winkler@intel.com \
--to=tomas.winkler@intel.com \
--cc=alexander.usyskin@intel.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.