From: kbuild test robot <lkp@intel.com>
To: Clark Wang <xiaoning.wang@nxp.com>
Cc: kbuild-all@01.org, "broonie@kernel.org" <broonie@kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Clark Wang <xiaoning.wang@nxp.com>
Subject: Re: [PATCH 2/5] spi: lpspi: Improve the stability of lpspi data transmission
Date: Wed, 24 Oct 2018 14:50:53 +0800 [thread overview]
Message-ID: <201810241441.htIAXFI1%fengguang.wu@intel.com> (raw)
In-Reply-To: <20181024024808.14485-2-xiaoning.wang@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 3563 bytes --]
Hi Clark,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on spi/for-next]
[also build test ERROR on next-20181019]
[cannot apply to v4.19]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Clark-Wang/spi-lpspi-Add-slave-mode-support-for-imx7ulp/20181024-125200
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 8.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=8.1.0 make.cross ARCH=xtensa
Note: the linux-review/Clark-Wang/spi-lpspi-Add-slave-mode-support-for-imx7ulp/20181024-125200 HEAD 37fc79ae346a636e850e4b90070c7d6e84b67b52 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
drivers/spi/spi-fsl-lpspi.c: In function 'fsl_lpspi_transfer_one':
>> drivers/spi/spi-fsl-lpspi.c:387:8: error: implicit declaration of function 'fsl_lpspi_txfifo_empty'; did you mean 'fsl_lpspi_set_cmd'? [-Werror=implicit-function-declaration]
ret = fsl_lpspi_txfifo_empty(fsl_lpspi);
^~~~~~~~~~~~~~~~~~~~~~
fsl_lpspi_set_cmd
cc1: some warnings being treated as errors
vim +387 drivers/spi/spi-fsl-lpspi.c
8e2c76586 Clark Wang 2018-10-24 365
8e2c76586 Clark Wang 2018-10-24 366 static int fsl_lpspi_transfer_one(struct spi_controller *controller,
5314987de Gao Pan 2016-11-22 367 struct spi_device *spi,
5314987de Gao Pan 2016-11-22 368 struct spi_transfer *t)
5314987de Gao Pan 2016-11-22 369 {
8e2c76586 Clark Wang 2018-10-24 370 struct fsl_lpspi_data *fsl_lpspi =
8e2c76586 Clark Wang 2018-10-24 371 spi_controller_get_devdata(controller);
5314987de Gao Pan 2016-11-22 372 int ret;
5314987de Gao Pan 2016-11-22 373
5314987de Gao Pan 2016-11-22 374 fsl_lpspi->tx_buf = t->tx_buf;
5314987de Gao Pan 2016-11-22 375 fsl_lpspi->rx_buf = t->rx_buf;
5314987de Gao Pan 2016-11-22 376 fsl_lpspi->remain = t->len;
5314987de Gao Pan 2016-11-22 377
5314987de Gao Pan 2016-11-22 378 reinit_completion(&fsl_lpspi->xfer_done);
8e2c76586 Clark Wang 2018-10-24 379 fsl_lpspi->slave_aborted = false;
8e2c76586 Clark Wang 2018-10-24 380
5314987de Gao Pan 2016-11-22 381 fsl_lpspi_write_tx_fifo(fsl_lpspi);
d2ad0a62d Gao Pan 2016-11-28 382
8e2c76586 Clark Wang 2018-10-24 383 ret = fsl_lpspi_wait_for_completion(controller);
8e2c76586 Clark Wang 2018-10-24 384 if (ret)
8e2c76586 Clark Wang 2018-10-24 385 return ret;
5314987de Gao Pan 2016-11-22 386
5314987de Gao Pan 2016-11-22 @387 ret = fsl_lpspi_txfifo_empty(fsl_lpspi);
d989eed20 Gao Pan 2016-12-02 388 if (ret)
d989eed20 Gao Pan 2016-12-02 389 return ret;
d989eed20 Gao Pan 2016-12-02 390
d989eed20 Gao Pan 2016-12-02 391 return 0;
5314987de Gao Pan 2016-11-22 392 }
5314987de Gao Pan 2016-11-22 393
:::::: The code at line 387 was first introduced by commit
:::::: 5314987de5e5f5e38436ef4a69328bc472bbd63e spi: imx: add lpspi bus driver
:::::: TO: Gao Pan <pandy.gao@nxp.com>
:::::: CC: Mark Brown <broonie@kernel.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 55232 bytes --]
next prev parent reply other threads:[~2018-10-24 6:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 2:50 [PATCH 1/5] spi: lpspi: Add slave mode support for imx7ulp Clark Wang
2018-10-24 2:50 ` [PATCH 2/5] spi: lpspi: Improve the stability of lpspi data transmission Clark Wang
2018-10-24 6:50 ` kbuild test robot [this message]
2018-10-24 2:50 ` [PATCH 3/5] spi: lpspi: Add 8qm/qxp support for lpspi Clark Wang
2018-10-24 2:50 ` [PATCH 4/5] spi: lpspi: enable runtime pm " Clark Wang
2018-10-24 6:06 ` kbuild test robot
2018-10-24 7:14 ` kbuild test robot
2018-10-24 2:50 ` [PATCH 5/5] spi: lpspi: CLK pin becomes low when CR_RST=1 Clark Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201810241441.htIAXFI1%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=broonie@kernel.org \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.